Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Phalcon\Support\Debug broken links #16223

Closed
Nazariy opened this issue Nov 22, 2022 · 2 comments · Fixed by #16230
Closed

[BUG]: Phalcon\Support\Debug broken links #16223

Nazariy opened this issue Nov 22, 2022 · 2 comments · Fixed by #16230
Assignees
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium

Comments

@Nazariy
Copy link

Nazariy commented Nov 22, 2022

The debug page is trying to load following files which is missing on

Also documentation links are hardcoded to version 4.0 in phalcon/Support/Debug.zep

/**
 * Generate a link to the official docs
 */
let classNameWithLink = "<a target=\"_new\" href=\"https://docs.phalcon.io/4.0/en/api/" . prepareUriClass . "\">" . className . "</a>";

To Reproduce

Steps to reproduce the behavior:

<?php

(new Phalcon\Support\Debug())->listen();

new UnknownClassName;

Perhaps those files can be loaded from other CDN service like cdnjs.com

Details

  • Phalcon version: 5.1
  • PHP Version: 8.1.12
  • Operating System: alpine-fpm
  • Installation type: Compiled from source
  • Zephir version (if any):
  • Server: Nginx
  • Other related info (Database, table schema):
@Nazariy Nazariy added bug A bug report status: unverified Unverified labels Nov 22, 2022
@niden
Copy link
Member

niden commented Nov 28, 2022

@Nazariy Thank you for this.

The links you posted have been fixed. I will fix the documentation link in Debug shortly

@niden niden added status: medium Medium 5.0 The issues we want to solve in the 5.0 release and removed status: unverified Unverified labels Nov 28, 2022
@niden niden self-assigned this Nov 28, 2022
@niden niden added this to Phalcon v5 Nov 28, 2022
@niden niden moved this to Backlog in Phalcon v5 Nov 28, 2022
@niden niden moved this from Backlog to In Progress in Phalcon v5 Nov 28, 2022
@niden niden mentioned this issue Nov 28, 2022
5 tasks
@niden niden linked a pull request Nov 28, 2022 that will close this issue
5 tasks
@niden
Copy link
Member

niden commented Nov 28, 2022

Resolved in #16230

@niden niden closed this as completed Nov 28, 2022
Repository owner moved this from In Progress to Implemented in Phalcon v5 Nov 28, 2022
@niden niden moved this from Implemented to Released in Phalcon v5 Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants