Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Filter:sanitize array - noRecursive #16199

Closed
niden opened this issue Nov 5, 2022 · 1 comment · Fixed by #16197
Closed

[BUG]: Filter:sanitize array - noRecursive #16199

niden opened this issue Nov 5, 2022 · 1 comment · Fixed by #16197
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium

Comments

@niden
Copy link
Member

niden commented Nov 5, 2022 •
edited
Loading

Hey, I was going after the new version and found that there seems to be an bug when we call sanitize with an array value, array sanitizers and noRecursive = true. The output is always the same as the initial value.

I think this change should do it as it goes to a previous way to handle this.

Credit: @lubatti
@niden niden added bug A bug report status: unverified Unverified status: medium Medium 5.0 The issues we want to solve in the 5.0 release and removed status: unverified Unverified labels Nov 5, 2022
@niden niden added this to Phalcon v5 Nov 5, 2022
@niden niden moved this to Backlog in Phalcon v5 Nov 5, 2022
@niden niden moved this from Backlog to In Progress in Phalcon v5 Nov 5, 2022
@niden niden linked a pull request Nov 5, 2022 that will close this issue
Fix no recursive array value with multiple sanitizers in Filter #16197
Merged
5 tasks
@niden
Copy link
Member Author

niden commented Nov 5, 2022

Resolved in #16197

@niden niden closed this as completed Nov 5, 2022
Repository owner moved this from In Progress to Implemented in Phalcon v5 Nov 5, 2022
@niden niden moved this from Implemented to Released in Phalcon v5 Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix no recursive array value with multiple sanitizers in Filter lubatti/cphalcon
1 participant
@niden