Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Form::label parameters #16180

Closed
niden opened this issue Oct 24, 2022 · 1 comment · Fixed by #16179
Closed

[BUG]: Form::label parameters #16180

niden opened this issue Oct 24, 2022 · 1 comment · Fixed by #16179
Assignees
@niden
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium

Comments

@niden
Copy link
Member

niden commented Oct 24, 2022

element::label is updated from array attributes = null to array attributes = []

Using this method with the default secondary argument will now cause an

"Fatal error: Uncaught TypeError" to be thrown
@niden niden added bug A bug report status: unverified Unverified status: medium Medium 5.0 The issues we want to solve in the 5.0 release and removed status: unverified Unverified labels Oct 24, 2022
@niden niden added this to Phalcon v5 Oct 24, 2022
@niden niden moved this to Backlog in Phalcon v5 Oct 24, 2022
@niden niden moved this from Backlog to In Progress in Phalcon v5 Oct 24, 2022
@niden niden linked a pull request Oct 24, 2022 that will close this issue
adjust default for form::label attributes #16179
Merged
@niden
Copy link
Member Author

niden commented Oct 24, 2022

Resolved in #16179

@niden niden closed this as completed Oct 24, 2022
Repository owner moved this from In Progress to Implemented in Phalcon v5 Oct 24, 2022
@niden niden moved this from Implemented to Released in Phalcon v5 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adjust default for form::label attributes 1RV34/cphalcon
1 participant
@niden