Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Dispacher: Exception on nullable module value (PHP 8.1) #15997

Closed
palcoder opened this issue Jun 18, 2022 · 1 comment · Fixed by #16009
Closed

[BUG]: Dispacher: Exception on nullable module value (PHP 8.1) #15997

palcoder opened this issue Jun 18, 2022 · 1 comment · Fixed by #16009
Assignees
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium

Comments

@palcoder
Copy link

palcoder commented Jun 18, 2022

Hello,

The dispatcher will throw the following exception when you pass a null value for the module parameter in route but when you pass an empty string it works fine.

Phalcon\Dispatcher\AbstractDispatcher::setModuleName(): Passing null to parameter #1 ($moduleName) of type string is deprecated

$router->add( '/session', [ 'module' => null, 'controller' => 'session', 'action' => 'index' ] );

@palcoder palcoder added bug A bug report status: unverified Unverified labels Jun 18, 2022
@niden niden self-assigned this Jul 1, 2022
@niden niden added status: medium Medium 5.0 The issues we want to solve in the 5.0 release and removed status: unverified Unverified labels Jul 5, 2022
@niden niden mentioned this issue Jul 5, 2022
5 tasks
@niden niden linked a pull request Jul 5, 2022 that will close this issue
5 tasks
@niden
Copy link
Member

niden commented Jul 10, 2022

Resolved in #16009

@niden niden closed this as completed Jul 10, 2022
@niden niden moved this to Implemented in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
@niden niden moved this from Implemented to Released in Phalcon v5 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants