Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR]: Annotations Reflection getReflectionConstant() or from getAttributes() #15919

Closed
okool opened this issue Mar 4, 2022 · 1 comment
Closed
Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request

Comments

@okool
Copy link

okool commented Mar 4, 2022

** support getReflectionConstant

now get \ReflectionClass
e.g

        $ref=new \ReflectionClass(static::class);
        $constRef=$ref->getReflectionConstant("xxx");
        $docBlock = $constRef->getDocComment();
        $refDatas = Reader::parseDocBlock($docBlock);
        $annotations= new \Phalcon\Annotations\Collection($refDatas);

to:

$annotations=(new Memory())->getConstant(static::class,'xxx')->getConstantsAnnotations();
@okool okool added the new feature request Planned Feature or New Feature Request label Mar 4, 2022
@ustmaestro ustmaestro mentioned this issue May 24, 2022
5 tasks
@niden
Copy link
Member

niden commented May 30, 2022

Resolved in #15970

@niden niden closed this as completed May 30, 2022
@niden niden added the 5.0 The issues we want to solve in the 5.0 release label May 30, 2022
@niden niden moved this to Implemented in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
@niden niden moved this from Implemented to Released in Phalcon v5 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request
Projects
Archived in project
Development

No branches or pull requests

2 participants