[NFR]: Remove Tag

[niden]

Remove Phalcon\Tag in favor of Phalcon\Html\TagFactory

[niden]

Part of this work has been resolved with #15826

Remaining

• test corrections once module-phalcon5 is ready from Codeception
• tagFactory injected into Volt : Di is injected into Volt so we can access TagFactory there
• Tag\Select needs to be created (using model)
• Complete removal of Tag

[niden]

The usage of Tag in Volt is causing issues. The methods that Tag uses all accept an array of parameters, and accordingly the code in Tag parses them for each relevant method. As such, Volt parses the parameters passed for say

text_field( param1, param2. ...)

and creates code like this:

$this->tag->textField([param1, param2, ...]);

With the new helpers this is not feasible because they are more specific on what they accept and what not. Therefore a straight up change from the Tag helpers to the TagFactory helpers is not possible. In addition, removing the Tag based syntax will result in huge problems for the developers, since they will have to upgrade everything in their views - and that is not a simple find/replace.

For now this will stay as is for v5. In v6 we will remove Tag completely but will allow developers to use the old syntax, so as not to force everyone to update all their views at once.

[niden]

Closing this - it will be addressed in v6