Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFR]: Refactor Phalcon\Crypt #15717

Closed
niden opened this issue Oct 17, 2021 · 1 comment · Fixed by #15718
Closed

[NFR]: Refactor Phalcon\Crypt #15717

niden opened this issue Oct 17, 2021 · 1 comment · Fixed by #15718
Assignees
@niden
Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility new feature request Planned Feature or New Feature Request

Comments

@niden
Copy link
Member

niden commented Oct 17, 2021 •
edited
Loading

Related:

#15270
#15271

Refactor Phalcon\Crypt

  • Move its to its own namespace (instead of root)
  • Organize exceptions
  • Create padding classes to pad/unpad strings when necessary based on different techniques
  • Create padding factory
  • Increase test coverage
  • Change ccm/gcm modes to store the authTag with the encryption string and process it with the decryption string

Thanks
@niden niden added the new feature request Planned Feature or New Feature Request label Oct 17, 2021
@niden niden self-assigned this Oct 17, 2021
@niden niden added 5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility labels Oct 17, 2021
This was referenced Oct 17, 2021
Closed
Merged
@niden niden linked a pull request Oct 18, 2021 that will close this issue
T15717 refactor crypt #15718
Merged
5 tasks
@niden
Copy link
Member Author

niden commented Oct 19, 2021

Resolved in #15718

@niden niden closed this as completed Oct 19, 2021
@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility new feature request Planned Feature or New Feature Request
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

T15717 refactor crypt
1 participant
@niden