Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Phalcon\Mvc\Model::getPreparedQuery should return QueryInterface instead of Query #15562

Closed
StudioMaX opened this issue Jun 30, 2021 · 1 comment · Fixed by #15736
Closed

[BUG]: Phalcon\Mvc\Model::getPreparedQuery should return QueryInterface instead of Query #15562

StudioMaX opened this issue Jun 30, 2021 · 1 comment · Fixed by #15736
Assignees
@niden
Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: medium Medium

Comments

@StudioMaX
Copy link
Contributor

Describe the bug
This seems to be the only place where only Phalcon\Mvc\Model\Query is supported as a return type, although any implementation of Phalcon\Mvc\Model\QueryInterface should be allowed.

cphalcon/phalcon/Mvc/Model.zep

Line 5222 in afa141d

private static function getPreparedQuery(var params, var limit = null) -> <Query>

To Reproduce
Steps to reproduce the behavior:

  • Create a new implementation of Phalcon\Mvc\Model\QueryInterface.

Expected behavior
Phalcon\Mvc\Model::getPreparedQuery should allow to return QueryInterface

Details

  • Phalcon version: 4.1.2
  • PHP Version:
  • Operating System:
  • Installation type: Compiling from source || installing via package manager
  • Zephir version (if any):
  • Server: Nginx | Apache | Other
  • Other related info (Database, table schema):
@StudioMaX StudioMaX added bug A bug report status: unverified Unverified labels Jun 30, 2021
@niden niden added 5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility status: medium Medium and removed status: unverified Unverified labels Oct 24, 2021
@niden niden mentioned this issue Oct 24, 2021
Merged
5 tasks
@niden niden linked a pull request Oct 24, 2021 that will close this issue
changed the getPreparedQuery return type to QueryInterface #15736
Merged
5 tasks
@niden
Copy link
Member

niden commented Oct 24, 2021

Resolved in #15736

@niden niden self-assigned this Oct 24, 2021
@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: medium Medium
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changed the getPreparedQuery return type to QueryInterface
3 participants
@niden @Jeckerson @StudioMaX