Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFR]: Remove top level classes: Version #15422

Closed
niden opened this issue Apr 21, 2021 · 1 comment · Fixed by #15423
Closed

[NFR]: Remove top level classes: Version #15422

niden opened this issue Apr 21, 2021 · 1 comment · Fixed by #15423
Labels
5.0 The issues we want to solve in the 5.0 release enhancement Enhancement to the framework new feature request Planned Feature or New Feature Request

Comments

@niden
Copy link
Member

niden commented Apr 21, 2021

  • Move Version from the top level namespace
  • Add it to a new Support namespace
  • Make it non static
@niden niden added new feature request Planned Feature or New Feature Request enhancement Enhancement to the framework 5.0 The issues we want to solve in the 5.0 release labels Apr 21, 2021
@niden niden mentioned this issue Apr 21, 2021
Merged
5 tasks
@niden niden linked a pull request Apr 21, 2021 that will close this issue
T15422 version top level #15423
Merged
5 tasks
@niden
Copy link
Member Author

niden commented Apr 21, 2021

Resolved in #15423

@niden niden closed this as completed Apr 21, 2021
@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5.0 The issues we want to solve in the 5.0 release enhancement Enhancement to the framework new feature request Planned Feature or New Feature Request
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

T15422 version top level
1 participant
@niden