Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR]: Phalcon 4 & Cssmin/Jsmin #14903

Closed
bhairava3 opened this issue Mar 10, 2020 · 5 comments
Closed

[NFR]: Phalcon 4 & Cssmin/Jsmin #14903

bhairava3 opened this issue Mar 10, 2020 · 5 comments
Labels
new feature request Planned Feature or New Feature Request

Comments

@bhairava3
Copy link

bhairava3 commented Mar 10, 2020

The documentation says that due to licensing restrictions, you cannot use jsmin in phalcon by default, but I did not find any restrictions with Douglas Crockford "https://github.com/douglascrockford/JSMin/blob/master/jsmin.c"
Why was this wonderful feature removed from the box?

https://docs.phalcon.io/4.0/en/assets#custom-filters
The current implementation of custom filters unfortunately does not work correctly, the filter is applied not to the overall result, but to each connected file.

Please, if possible, return the minification functionality from phalcon 3.4

@bhairava3 bhairava3 added the new feature request Planned Feature or New Feature Request label Mar 10, 2020
@CameronHall
Copy link
Contributor

The license must have changed. See #10118.

@niden
Copy link
Member

niden commented Apr 10, 2020

Tracked in #14608

@niden niden closed this as completed Apr 10, 2020
@RobinvanderVliet
Copy link
Contributor

The documentation says that due to licensing restrictions, you cannot use jsmin in phalcon by default, but I did not find any restrictions with Douglas Crockford "https://github.com/douglascrockford/JSMin/blob/master/jsmin.c"
Why was this wonderful feature removed from the box?

"The Software shall be used for Good, not Evil."

More information: https://en.wikipedia.org/wiki/Douglas_Crockford#Software_license_for_%22Good,_not_Evil%22

@niden
Copy link
Member

niden commented Dec 18, 2022

We had lengthy discussions with Remi Collet, who maintains an excellent RPM repository, and he found issues with the licensing. As such, we removed it so as not to have any issues. A different solution will be added as we move towards v6 for sure because this is a feature that the community wants.

@niden
Copy link
Member

niden commented Dec 18, 2022

Actually, reading a bit more about this, the fact that that statement exists is a vague restriction and therefore not free as in open source. Someone might want to use the software for evil (at least how some people might perceive the definition of evil). As such, that becomes a restriction, so it is not free.

Crazy world!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature request Planned Feature or New Feature Request
Projects
None yet
Development

No branches or pull requests

4 participants