-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFR]: Phalcon 4 & Cssmin/Jsmin #14903
Comments
The license must have changed. See #10118. |
Tracked in #14608 |
"The Software shall be used for Good, not Evil." More information: https://en.wikipedia.org/wiki/Douglas_Crockford#Software_license_for_%22Good,_not_Evil%22 |
We had lengthy discussions with Remi Collet, who maintains an excellent RPM repository, and he found issues with the licensing. As such, we removed it so as not to have any issues. A different solution will be added as we move towards v6 for sure because this is a feature that the community wants. |
Actually, reading a bit more about this, the fact that that statement exists is a vague restriction and therefore not free as in open source. Someone might want to use the software for evil (at least how some people might perceive the definition of evil). As such, that becomes a restriction, so it is not free. Crazy world! |
The documentation says that due to licensing restrictions, you cannot use jsmin in phalcon by default, but I did not find any restrictions with Douglas Crockford "https://github.com/douglascrockford/JSMin/blob/master/jsmin.c"
Why was this wonderful feature removed from the box?
https://docs.phalcon.io/4.0/en/assets#custom-filters
The current implementation of custom filters unfortunately does not work correctly, the filter is applied not to the overall result, but to each connected file.
Please, if possible, return the minification functionality from phalcon 3.4
The text was updated successfully, but these errors were encountered: