-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Http\Response can't setCookies #14602
Labels
Comments
I discovered this bug because I was creating the test. So if you correct this bug, can I pull request my test ? |
/cc @niden |
Create the pr with the test that fails. We merge iy then fix the code so that test passes
…-------- Original Message --------
On Dec 8, 2019, 12:45, Anton Vasiliev wrote:
/cc ***@***.***(https://github.com/niden)
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#14602?email_source=notifications&email_token=AAIGE6EMI7KFPGC3SCJN2QDQXUXFJA5CNFSM4JX6BPX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGHEXXI#issuecomment-562973661), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAIGE6D4KS3GQTNF4XN6Z2LQXUXFJANCNFSM4JX6BPXQ).
|
niden
added a commit
that referenced
this issue
Dec 9, 2019
niden
added a commit
that referenced
this issue
Dec 9, 2019
Resolved in #14604 Thank you @jenovateurs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The function setCookies needs an object which implements Phalcon\Http\Response\CookiesInterface.
https://github.com/phalcon/cphalcon/blob/4.0.x/phalcon/Http/Response.zep
This interface doesn't exist, Cookie without the s exists.
If I'm right, I think that the function setCookies should be renamed to setCookie.
The text was updated successfully, but these errors were encountered: