Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Http\Response can't setCookies #14602

Closed
jenovateurs opened this issue Dec 8, 2019 · 4 comments
Closed

[BUG]: Http\Response can't setCookies #14602

jenovateurs opened this issue Dec 8, 2019 · 4 comments
Labels
bug A bug report status: medium Medium

Comments

@jenovateurs
Copy link
Contributor

jenovateurs commented Dec 8, 2019

The function setCookies needs an object which implements Phalcon\Http\Response\CookiesInterface.
https://github.com/phalcon/cphalcon/blob/4.0.x/phalcon/Http/Response.zep
This interface doesn't exist, Cookie without the s exists.
If I'm right, I think that the function setCookies should be renamed to setCookie.

@jenovateurs
Copy link
Contributor Author

I discovered this bug because I was creating the test. So if you correct this bug, can I pull request my test ?

@Jeckerson
Copy link
Member

/cc @niden

@niden
Copy link
Member

niden commented Dec 8, 2019 via email

@niden
Copy link
Member

niden commented Dec 9, 2019

Resolved in #14604

Thank you @jenovateurs

@niden niden closed this as completed Dec 9, 2019
@niden niden added bug A bug report status: medium Medium and removed Bug - Medium labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: medium Medium
Projects
None yet
Development

No branches or pull requests

3 participants