Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid return type of Phalcon\Flash\AbstractFlash methods #14349

Closed
sergeyklay opened this issue Sep 2, 2019 · 1 comment
Closed

Invalid return type of Phalcon\Flash\AbstractFlash methods #14349

sergeyklay opened this issue Sep 2, 2019 · 1 comment
Assignees
@niden
Labels
bug A bug report status: medium Medium
Milestone
4.0.0

Comments

@sergeyklay
Copy link
Contributor

The Following methods should always return void, not string:

  • Phalcon\Flash\AbstractFlash::error
  • Phalcon\Flash\AbstractFlash::notice
  • Phalcon\Flash\AbstractFlash::success
  • Phalcon\Flash\AbstractFlash::warning
@sergeyklay sergeyklay added this to the 4.0.0 milestone Sep 2, 2019
@niden niden mentioned this issue Sep 6, 2019
Merged
5 tasks
niden added a commit that referenced this issue Sep 7, 2019
@niden
[#14349] - Changed the interfaces and added escaper to the constructor
a185740
niden added a commit that referenced this issue Sep 7, 2019
@niden
[#14349] - Correcting tests
6000b5a
niden added a commit that referenced this issue Sep 7, 2019
@niden
[#14349] - Fixing tests
ced0bb4
niden added a commit that referenced this issue Sep 7, 2019
@niden
[#14349] - Fixing test
b562414
niden added a commit that referenced this issue Sep 7, 2019
@niden
[#14349] - Added _before in the helper class
373894b
niden added a commit that referenced this issue Sep 7, 2019
@niden
[#14349] - Corrected class name
a92d80e
niden added a commit that referenced this issue Sep 7, 2019
@niden
[#14349] - Adjusting the interfaces again
8ad287c
niden added a commit that referenced this issue Sep 7, 2019
@niden
[#14349] - Updated the changelog
e9540a4
niden added a commit that referenced this issue Sep 7, 2019
@niden
Merge branch 'T14359-tidy-up-di-classes' of https://github.com/niden/…
4899007 
…cphalcon into niden-T14359-tidy-up-di-classes

* 'T14359-tidy-up-di-classes' of https://github.com/niden/cphalcon:
  [#14359] - Fixing appveyor
  [#14359] - Updated changelog
  [#14359] - Renamed Injectable again
  [#14359] - Trying require
  [#14359] - trying a hack for codeception
  [#14359] - Renamed DI classes to abstract*
  [#14349] - Updated the changelog
  [#14349] - Adjusting the interfaces again
  [#14349] - Corrected class name
  [#14349] - Added _before in the helper class
  [#14349] - Fixing test
  [#14349] - Fixing tests
  [#14349] - Correcting tests
  [#14349] - Changed the interfaces and added escaper to the constructor
niden added a commit that referenced this issue Sep 7, 2019
@niden
Merge branch 'niden-T14359-tidy-up-di-classes' into 4.0.x
cb74b41 
* niden-T14359-tidy-up-di-classes:
  [#14359] - Fixing appveyor
  [#14359] - Updated changelog
  [#14359] - Renamed Injectable again
  [#14359] - Trying require
  [#14359] - trying a hack for codeception
  [#14359] - Renamed DI classes to abstract*
  [#14349] - Updated the changelog
  [#14349] - Adjusting the interfaces again
  [#14349] - Corrected class name
  [#14349] - Added _before in the helper class
  [#14349] - Fixing test
  [#14349] - Fixing tests
  [#14349] - Correcting tests
  [#14349] - Changed the interfaces and added escaper to the constructor
@niden
Copy link
Member

niden commented Sep 7, 2019

Resolved

@niden niden closed this as completed Sep 7, 2019
@niden niden added bug A bug report status: medium Medium and removed Bug - Medium labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

Labels
bug A bug report status: medium Medium
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@niden @sergeyklay