Calling model::create() does an _exists() twice if the record doesn't exist

[maxgalbu]

Expected and Actual Behavior

Calling model::create() does an _exists() twice if the record doesn't exist.

cphalcon/phalcon/Mvc/Model.zep

Line 964 in 2be495d

if this->_exists(metaData, this->getReadConnection()) {

cphalcon/phalcon/Mvc/Model.zep

Line 2316 in 2be495d

let exists = this->_exists(metaData, readConnection);

Details

• Phalcon version: (php --ri phalcon) all the way to 4.0.x from 3.0.x
• PHP Version: (php -v) any
• Operating System: any
• Installation type: any
• Zephir version (if any): none
• Server: any
• Other related info (Database, table schema): any

😞 😞

[niden]

Looking at the code it kind of makes sense because create() throws an exception if the record exists already, where save() will change to update mode if the record exists.

Not sure how to refactor this to keep on offering the same functionality. We can certainly remove create() because it does the same thing as save() but then you will lose the functionality of having an exception thrown if the record exists.

Thoughts?

[david-duncan]

There is definitely a bug here -

create() should check the write connection.

Replica lag means that you will never be 100% correct when checking if a record exists if you check the read connection.

[niden]

@david-duncan good catch

[ruudboon]

Maybe we could set operationMade to OP_CREATE in the create method before calling save and skip the check if it's already defined?

[niden]

Resolved

[maxgalbu]

Wait it still does two selects... since we do a check on the write connection, the check on the read one is not useful... this will slow down the app if there are a lot of inserts