[BUG] [CRASH] Segmentation Fault in zim_Phalcon_Acl_Adapter_Memory_dropResourceAccess

[ghost]

Sample code:

<?php
$a = new \Phalcon\Acl\Adapter\Memory();
$a->dropResourceAccess('resource', 'accesslist');
?>

Happens because:

PHP_METHOD(Phalcon_Acl_Adapter_Memory, dropResourceAccess){

    zval *resource_name, *access_list, *access_name = NULL;
    zval *access_key = NULL;
    PHALCON_MM_GROW();

    phalcon_fetch_params(1, 2, 0, &resource_name, &access_list);

    if (Z_TYPE_P(access_list) == IS_ARRAY) { 
        /* ... */
    } else {
        PHALCON_INIT_NVAR(access_key);
        /* access_name == NULL, segfault :-( */
        PHALCON_CONCAT_VSV(access_key, resource_name, "!", access_name);
        phalcon_unset_property_array(this_ptr, SL("_accessList"), access_key TSRMLS_CC);
    }

    /* ... */
}

[ghost]

@phalcon Need your help here, I am not sure what access_key should be in this case…

[ghost]

I have replaced it with

PHALCON_CONCAT_VSV(access_key, resource_name, "!", access_list);

so far, not sure if it is OK.

[ghost]

Fixed in #1375