Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add method close() to Phalcon\Session\AdapterInterface #13535

Closed
michalzielanski opened this issue Oct 18, 2018 · 2 comments
Closed

Please add method close() to Phalcon\Session\AdapterInterface #13535

michalzielanski opened this issue Oct 18, 2018 · 2 comments
Labels
enhancement Enhancement to the framework
Milestone

Comments

@michalzielanski
Copy link

Please add the close method in the session adapters. For Phalcon\Session\Adapter\Files, the method should call session_write_close(). This will allow to close the session and unlock the session file.

http://konrness.com/php5/how-to-prevent-blocking-php-requests/
https://stackoverflow.com/questions/13651195/long-running-background-php-script-blocks-other-php-pages-until-it-is-finished

@Jurigag
Copy link
Contributor

Jurigag commented Oct 18, 2018

Well it's actually good idea, i actually even used it for event source that you need to close it to make everything working properly.

@Jurigag Jurigag added the enhancement Enhancement to the framework label Oct 18, 2018
@Jurigag Jurigag added this to the 4.0.0 milestone Oct 18, 2018
@niden niden mentioned this issue Dec 21, 2018
3 tasks
@niden
Copy link
Member

niden commented Dec 21, 2018

@michalzielanski Thank you for reporting this. Addressed in #13673

@niden niden closed this as completed Dec 21, 2018
@niden niden added the 4.0 label Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the framework
Projects
None yet
Development

No branches or pull requests

3 participants