Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger Interface (PSR-3) #13438

Closed
sergeyklay opened this issue Jul 16, 2018 · 5 comments
Closed

Logger Interface (PSR-3) #13438

sergeyklay opened this issue Jul 16, 2018 · 5 comments
Labels
breaks bc Functionality that breaks Backwards Compatibility discussion Request for comments and discussion new feature request Planned Feature or New Feature Request
Milestone
4.0.0

Comments

@sergeyklay
Copy link
Contributor

sergeyklay commented Jul 16, 2018 •
edited
Loading

Phalcon's logger must be fully compatible with Logger Interface (PSR-3) for v4.0.0

Refs:
@sergeyklay sergeyklay added the new feature request Planned Feature or New Feature Request label Jul 16, 2018
@sergeyklay sergeyklay added this to the 4.0.0 milestone Jul 16, 2018
@sergeyklay sergeyklay added discussion Request for comments and discussion breaks bc Functionality that breaks Backwards Compatibility labels Jul 16, 2018
@sergeyklay sergeyklay mentioned this issue Jul 16, 2018
Closed
3 tasks
@niden niden mentioned this issue Dec 6, 2018
Merged
3 tasks
niden added a commit that referenced this issue Dec 7, 2018
@niden
[#13438] - Removed the multiple adapter logger
c36bfde
niden added a commit that referenced this issue Dec 7, 2018
@niden
[#13438] - Updated nanobox files and tests README
29443bd
niden added a commit that referenced this issue Dec 7, 2018
@niden
[#13438] - Work on the logger for PSR3
d34d610
niden added a commit that referenced this issue Dec 7, 2018
@niden
[#13438] - Added Logger\Item tests
5ae93ca
niden added a commit that referenced this issue Dec 7, 2018
@niden
[#13438] - Restructure on the logger tests
17de454
niden added a commit that referenced this issue Dec 7, 2018
@niden
[#13438] - Added utility to generate test stubs
aa2cd09
niden added a commit that referenced this issue Dec 7, 2018
@niden
[#13438] - Corrections to the Json formatter; Added date format for it
19167c1
niden added a commit that referenced this issue Dec 7, 2018
@niden
[#13438] - Added more tests for the Json formatter
86dea08
niden added a commit that referenced this issue Dec 7, 2018
@niden
[#13438] - Corrected tests and code for logger/formatter/json; Enable…
3326c0d 
…d syslog formatter
niden added a commit that referenced this issue Dec 7, 2018
@niden
[#13438] - Work on the formatters and adapters (file/syslog); Removed…
3fce42b 
… not needed test stubs
niden added a commit that referenced this issue Dec 7, 2018
@niden
[#13438] - Added more tests for formatters
3206027
niden added a commit that referenced this issue Dec 7, 2018
@niden
[#13438] - Added Logger trait and tests for log levels
2fd7956
niden added a commit that referenced this issue Dec 7, 2018
@niden
[#13438] - Added constructor test
104d320
niden added a commit that referenced this issue Dec 7, 2018
@niden
[#13438] - Cosmetic changes
e532f22
niden added a commit that referenced this issue Dec 7, 2018
@niden
[#13438] - Reformatting code
2f53b7b
niden added a commit that referenced this issue Dec 7, 2018
@niden
[#13438] - Added exclude Adapters in the Logger
eb9dc2f
niden added a commit that referenced this issue Dec 7, 2018
@niden
[#13438] - Sanity check for someone not passing a string
feb6dd9
niden added a commit that referenced this issue Dec 7, 2018
@niden
[#13438] - Added "excludeAdapters" functionality for the logger
30643d1
niden added a commit that referenced this issue Dec 7, 2018
@niden
[#13438] - Correction to the logger trait; Added more tests
7a66164
niden added a commit that referenced this issue Dec 7, 2018
@niden
[#13438] - Corrections for the excludeAdapter and inTransaction
3c3e2f7
niden added a commit that referenced this issue Dec 7, 2018
@niden
[#13438] - Corrected some tests; Added more file ones
bcb4d0f
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Added more tests for formatters
b20f27c
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Added Logger trait and tests for log levels
369ba52
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Added constructor test
0a36194
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Cosmetic changes
4c07f0a
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Reformatting code
977e39a
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Added exclude Adapters in the Logger
86f8f57
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Sanity check for someone not passing a string
759e07f
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Added "excludeAdapters" functionality for the logger
9ea4da1
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Correction to the logger trait; Added more tests
f3670b5
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Corrections for the excludeAdapter and inTransaction
e65deca
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Corrected some tests; Added more file ones
9f2497b
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Added Stream adapter file tests
cac13c0
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - More logger tests
2f1d938
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Removed logger file adapter; consolidated it in str…
25ad3b4 
…eam. Adjusted tests; Added syslog tests
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Renamed the base folder for the tests
b275352
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Work on the syslog adapter
7cd9ca4
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Minor corrections to the adapter; Added more tests
a3aac66
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - PHPCS
511241b
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Renamed blackhole adapter to noop. Added tests
96847b0
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Correction to the syslog adapter; Added more tests
4cb7b9f
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Work on the Factory; Wrote more tests for it
fda0731
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Corrected interface
087b18e
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - More corrections to the interface
e0243a5
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Updated the CHANGELOG
bafd751
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Fixed tabs
b43c637
CameronHall pushed a commit to CameronHall/cphalcon that referenced this issue Dec 8, 2018
@niden @CameronHall
[phalcon#13438] - Added docblock
84cef57
@virgofx
Copy link
Contributor

virgofx commented Dec 9, 2018

@niden I was looking for that in the code ... I see now. So in short, we implement PSR .. meaning it will now be a dependency for Phalcon. Interesting ... I see a little bit of a chicken and egg thing and this potentially becoming more of an issue in the future. I'm not saying it's bad per say ... however, it means that the bundled extension requires autoloaded classes to be loaded ahead of time -- not sure how this will scale.

niden added a commit that referenced this issue Dec 9, 2018
@niden
Merge branch 'alexbusu-scope-sql-col-aliases' into 4.0.x
2cca3ea 
* alexbusu-scope-sql-col-aliases: (48 commits)
  CLI parameters now work like MVC parameters.
  Fixed Security Tests segmentation fault
  Added retainer for current session token in order to be able to validate fields after regenerating the token. Added string casting to userToken.
  Update di.zep
  Scope SQL Column Aliases (on nesting level)
  [NF] Micro: Response handler #12452
  Added Codecov token [skip appveyor]
  [#13438] - Added docblock
  [#13438] - Fixed tabs
  [#13438] - Updated the CHANGELOG
  [#13438] - More corrections to the interface
  [#13438] - Corrected interface
  [#13438] - Work on the Factory; Wrote more tests for it
  [#13438] - Correction to the syslog adapter; Added more tests
  [#13438] - Renamed blackhole adapter to noop. Added tests
  [#13438] - PHPCS
  [#13438] - Minor corrections to the adapter; Added more tests
  [#13438] - Work on the syslog adapter
  [#13438] - Renamed the base folder for the tests
  [#13438] - Removed logger file adapter; consolidated it in stream. Adjusted tests; Added syslog tests
  ...
@niden
Copy link
Member

niden commented Dec 31, 2018

@virgofx Sorry for the late reply, just finished scanning my emails :)

Yes it is a chicken and egg situation. There is no other way that we know of to include the PSR extension so that we can take advantage of the PSR interfaces and offer PSR compliance per se.

I think now that alpha is out and we are learning as we go, it will become much easier for people to install the package especially from rpm/deb distributions because we could make PSR a dependency.

@niden niden added the 4.0 label Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaks bc Functionality that breaks Backwards Compatibility discussion Request for comments and discussion new feature request Planned Feature or New Feature Request
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
3 participants
@virgofx @niden @sergeyklay