Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsMin breaks remote url in collection #1324

Closed
TomaszJanusz opened this issue Oct 2, 2013 · 1 comment
Closed

JsMin breaks remote url in collection #1324

TomaszJanusz opened this issue Oct 2, 2013 · 1 comment
Labels
bug A bug report status: medium Medium

Comments

@TomaszJanusz
Copy link

In a scenario where we want to be minified file, but loaded from an external domain best of my knowledge the code should look like this:

$this->assets->collection('jsFooter')
->setLocal(false)
->join(true)
->setPrefix('http://cdn.example.com/')
->setSourcePath($JsDir.$this->config->assets->srcDir)
->setTargetPath($JsDir.'footer.js')
->setTargetUri('header.js')
->addFilter(new Phalcon\Assets\Filters\Jsmin())
->addJs('jquery.min.js');

But PhalconPHP generating this:

<script src="/http://cdn.example.com/footer.js" type="text/javascript"></script>

instead of:

<script src="http://cdn.example.com/footer.js" type="text/javascript"></script>

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@phalcon
Copy link
Collaborator

phalcon commented Oct 3, 2013

Duplicate of #1157

@phalcon phalcon changed the title JsMin breaks remote url in collection JsMin breaks remote url in collection Sep 10, 2014
@niden niden added bug A bug report status: medium Medium and removed Bug - Medium labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: medium Medium
Projects
None yet
Development

No branches or pull requests

3 participants