Skip to content

[NFR] JsonSerializable for all Message classes #13113

Closed
@grigoriy-ivanov

Description

It will make code more simple when we are sending json response.
At the moment:

$messages = $robot->getMessages();
foreach ($messages as $message) {
    $response[] = $message->getText();
 }
$request->setJsonContent($response);

I would like to:

$messages = $robot->getMessages();
$request->setJsonContent($messages);

P.S. Phalcon has two different MessageInterfaces. Maybe should are be merged into one?

Metadata

Assignees

Labels

staleStale issue - automatically closed

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions