Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container interface (PSR-11) #12295

Closed
sergeyklay opened this issue Oct 6, 2016 · 10 comments
Closed

Container interface (PSR-11) #12295

sergeyklay opened this issue Oct 6, 2016 · 10 comments
Labels
breaks bc Functionality that breaks Backwards Compatibility discussion Request for comments and discussion new feature request Planned Feature or New Feature Request
Milestone

Comments

@sergeyklay
Copy link
Contributor

sergeyklay commented Oct 6, 2016

Phalcon's DI must be fully compatible with Container interface (PSR-11) for v4.0.0


Refs:

@sergeyklay sergeyklay added this to the 4.0.0 milestone Oct 6, 2016
@virgofx
Copy link
Contributor

virgofx commented Oct 6, 2016

How would this be implemented? Create similar container interface or would Phalcon somehow import/reference Psr* packages?

@sergeyklay
Copy link
Contributor Author

sergeyklay commented Oct 6, 2016

I need to research best way

@Jurigag
Copy link
Contributor

Jurigag commented Oct 6, 2016

@virgofx the same question is for psr request i guess

@sergeyklay sergeyklay added the discussion Request for comments and discussion label Oct 6, 2016
@SidRoberts
Copy link
Contributor

I personally find this PSR a bit vague (it only has two methods) so I don't think it's absolutely essential that Phalcon should actually implement the interface. I think just following the spec should be enough.

Two things I'd like to recommend:

@sergeyklay sergeyklay added the breaks bc Functionality that breaks Backwards Compatibility label Jul 17, 2017
@stale
Copy link

stale bot commented Apr 16, 2018

Thank you for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please feel free to either reopen this issue or open a new one. We will be more than happy to look at it again! You can read more here: https://blog.phalconphp.com/post/github-closing-old-issues

@stale stale bot added the stale Stale issue - automatically closed label Apr 16, 2018
@sergeyklay sergeyklay reopened this May 2, 2018
@stale stale bot removed the stale Stale issue - automatically closed label May 2, 2018
@sergeyklay sergeyklay changed the title [NFR] Container Interface Container interface (PSR-11) Jul 16, 2018
@sergeyklay
Copy link
Contributor Author

@dragoonis Just assigned to you.

@sergeyklay sergeyklay added new feature request Planned Feature or New Feature Request and removed New Feature Request labels Jul 16, 2018
@sergeyklay sergeyklay mentioned this issue Jul 16, 2018
3 tasks
@Idrinth
Copy link
Contributor

Idrinth commented Aug 29, 2018

would likely be easiest for users if phalcon would just contain the psr-interfaces - having a similar one is not really going to help out much, since their implementations and the interfaces themselves would not be easily exchangeable.

Edit: there seems to be an extension that'd also provide them, so maybe depend on that? https://github.com/jbboehr/php-psr

@dschissler

This comment was marked as abuse.

@niden
Copy link
Member

niden commented Dec 17, 2018

@Idrinth That is the package we are using for the interfaces (v4)

@niden niden mentioned this issue Dec 22, 2018
3 tasks
niden added a commit that referenced this issue Dec 23, 2018
niden added a commit that referenced this issue Dec 23, 2018
niden added a commit that referenced this issue Dec 23, 2018
@niden
Copy link
Member

niden commented Dec 23, 2018

Implemented

@niden niden closed this as completed Dec 23, 2018
@niden niden added the 4.0 label Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks bc Functionality that breaks Backwards Compatibility discussion Request for comments and discussion new feature request Planned Feature or New Feature Request
Projects
None yet
Development

No branches or pull requests

8 participants