NFR: Add module name to module class name format in Application::registerModules

[dschissler]

Currently Phalcon module setup is a bit hacky because there is some overlap of concerns between the Loader and Application and modules. The Application class has been doing a poor man's loading to get the module definitions loaded up when the normal Loader class is fully capable of being used with the Loader::registerClasses method.

Currently if one wants to use the more correct approach then the following format must be used:

$application = new Application($di);
$application->registerModules([
    'org'   => ['className' => 'Project\Modules\Org\Module'],
    'site'  => ['className' => 'Project\Modules\Site\Module'],
    'admin' => ['className' => 'Project\Modules\Admin\Module'],
    'api'   => ['className' => 'Project\Modules\Api\Module']
]);

I propose that this could be made to look like the following while maintaining BC with the semver 3 series.

$application = new Application($di);
$application->registerModules([
    'org'   => 'Project\Modules\Org\Module',
    'site'  => 'Project\Modules\Site\Module',
    'admin' => 'Project\Modules\Admin\Module',
    'api'   => 'Project\Modules\Api\Module'
]);

Then I propose that late into 3.* series (1-2 years from now) that the className => ... format should throw a deprecation warning and then this format should be removed in the 4.0 series for a breaking change.

Update This is also possible:

$application = new Application($di);
$application->registerModules([
    'org'   => OrgModule::class,
    'site'  => SiteModule::class,
    'admin' => AdminModule::class,
    'api'   => Api::Module,
]);

[Jurigag]

Also what about adding option to load whole module on bootstraping ? Like execute registerNamespaces and registerServices always so certain module can be used across all modules ?

[Jurigag]

Yea i know, but what if someone need such a feature ? Right now you need to do some nasty things like create module class on your own and call methods, or register namespaces from other module and set proper services in other module and such stuff.

[niden]

Closing in favor of #13855. Will revisit if the community votes for it, or in later versions.