[BUG] Phalcon\Http\Response::redirect()

[tugrul]

Prepends "/" character internally.

following cases relevant to browser's behavior

$response->redirect('foo/bar');
// actual header (Location: /foo/bar) that means relative to actual domain
// expected header (Location: foo/bar) that means relative to actual path

$response->redirect('/foo/bar');
// actual header (Location: //foo/bar) that means scheme related foo domains bar path
// expected header (Location: /foo/bar) that means relative to actual domain

also there is no requirement to indicate external redirects with second parameter

$response->redirect('http://google.com');
// actual header (Location:/http://google.com)
// expected header (Location: http://google.com)

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[tugrul]

I used the function like following to escape from bug.

$response->redirect('foo/bar', true);

[viktoras25]

Response class only calls $this->getDi()->get('url')->get($url). The actual concatenation is happening here:

cphalcon/ext/mvc/url.c

Line 190 in ea95b05

PHALCON_CONCAT_VVV(base_uri, slash, uri, slash);

I'm note sure though what changing this place may also affect. If it's not affecting much, I may try to fix it later.

[viktoras25]

Can you try

$this->getDi()->get('url')->setBaseUri("");

in the bootstrapping file. Would it fix your issue?

[dreamsxin]

$response->redirect("http://google.com", true);

[ghost]

@tugrul External redirects (where the URL explicitly specifies the protocol) no longer require $external parameter — in this case Phalcon automatically detects that the redirect is external.

[Green-Cat]

@phalcon @andresgutierrez
This is fixed.

[ngethe]

I use this
$this->response->redirect('http://google.com');
from controller