Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in \Phalcon\Text::dynamic() #11215

Closed
mzf opened this issue Dec 11, 2015 · 5 comments
Closed

Error in \Phalcon\Text::dynamic() #11215

mzf opened this issue Dec 11, 2015 · 5 comments
Assignees
@sergeyklay
Labels
enhancement Enhancement to the framework
Milestone
3.0.0

Comments

@mzf
Copy link

mzf commented Dec 11, 2015

Please replace on https://github.com/phalcon/cphalcon/blame/master/phalcon/text.zep#L272
let words = explode("|", matches[1]);
to
let words = explode(separator, matches[1]);
Green-Cat added a commit to Green-Cat/cphalcon that referenced this issue Dec 11, 2015
@Green-Cat
Fixes phalcon#11215
d63151e
@mzf
Copy link
Author

mzf commented Dec 11, 2015

Thanks!

@mzf
Copy link
Author

mzf commented Dec 15, 2015

Not fixed yet?

@mzf
Copy link
Author

mzf commented Jun 22, 2016

Please fix it

@sergeyklay sergeyklay self-assigned this Jun 22, 2016
@sergeyklay sergeyklay added this to the 2.1.0 milestone Jun 22, 2016
@sergeyklay sergeyklay added the enhancement Enhancement to the framework label Jun 22, 2016
@sergeyklay sergeyklay mentioned this issue Jun 27, 2016
Merged
@sergeyklay
Copy link
Contributor

Fixed in the 2.1.x branch.

@mzf
Copy link
Author

mzf commented Jun 27, 2016

Cool! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergeyklay sergeyklay

Labels
enhancement Enhancement to the framework
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@sergeyklay @mzf