[BUG] \Phalcon\Debug Array to string conversion

[beermeat]

public function indexAction()
{
    throw new \Exception('sss');
}

make request:
/?var[]=1&var[]=2

and get the error (notice) "Array to string conversion"

[dreamsxin]

Could you please post the code that reproduces the bug?

[ovr]

@dreamsxin
Code

<?php
ini_set('display_errors', 1);
error_reporting(-1);
(new \Phalcon\Debug)->listen();
throw new Exception('fdsfsdf');

Screenshot http://gyazo.com/b6a5c3c618b28e4cc5bda59565ed8e9d
See Request Tab i think maybe use var_dump() for varibles or encode to json if is n`t string
url http://host/?var[]=1&var[]=2

[dreamsxin]

You are right.
I try fix it.

                        if (Z_TYPE_P(value) == IS_ARRAY) {
                                PHALCON_INIT_VAR(joined_value);
                                phalcon_fast_join_str(joined_value, SL(", "), value TSRMLS_CC);
                                PHALCON_SCONCAT_SVSVS(html, "<tr><td class=\"key\">", key_request, "</td><td>Array(", joined_value, ")</td></tr>");
                        } else {
                                PHALCON_SCONCAT_SVSVS(html, "<tr><td class=\"key\">", key_request, "</td><td>", value, "</td></tr>");
                        }

[ghost]

@dreamsxin Please try

http://host/?var[1][]=1&var[1][]=2

and see if it works

[ovr]

@dreamsxin @sjinks Maybe the best way convert to json in value td if isnt string?

[dreamsxin]

When using recursion. I decided to use zend_print_zval_r output to buffer.

                        if (Z_TYPE_P(value) == IS_ARRAY) {
                                PHALCON_INIT_NVAR(joined_value);
                                phalcon_ob_start(TSRMLS_C);
                                zend_print_zval_r(value, 0);
                                phalcon_ob_get_contents(joined_value TSRMLS_CC);
                                phalcon_ob_end_clean(TSRMLS_C);
                                PHALCON_SCONCAT_SVSVS(html, "<tr><td class=\"key\">", key_request, "</td><td>", joined_value, "</td></tr>");
                        } else {
                                PHALCON_SCONCAT_SVSVS(html, "<tr><td class=\"key\">", key_request, "</td><td>", value, "</td></tr>");
                        }

[beermeat]

maybe it would be better to use an existing method _getVarDump?

[dreamsxin]

@tema87 you are right.

[phalcon]

This is fixed in 1.3.0