Database connection can't use persistent option

[ucando]

I use postgresql, and I follow the phalcon's documents to set the persistent option, the code below

$db = new DbAdapter([
    "host" => $config->database->host,
    "port" => $config->database->port,
    "username" => $config->database->username,
    "password" => $config->database->password,
    "dbname" => $config->database->dbname,
    "persistent" => true
  ]);

It cause fatal error: SQLSTATE[08006] [7] invalid connection option "persistent". I must change my code like this:

$db = new DbAdapter([
    "host" => $config->database->host,
    "port" => $config->database->port,
    "username" => $config->database->username,
    "password" => $config->database->password,
    "dbname" => $config->database->dbname,
    "options" => [
        PDO::ATTR_PERSISTENT => true
      ]
  ]);

and the code can work.

is it a bug? or just the document is wrong?

[pauliuspetronis]

I think it's a small bug :)

I think this block has to be before fetch dnsAttributes and unset descriptor["persistent"]. Otherwise persistent variable is joined to dsnAttributes and PostgreSql throw error about it.

[andresgutierrez]

This is fixed in the 2.0.3 branch

[pauliuspetronis]

I created pull request #10489. @andresgutierrez - your fix did not resolve this problem. Because persistent is included in to dnsAttributes.