Removing warnings when running unit tests

Author: Philippe Hanrigou

test/unit/selenium/client/extensions_test.rb

@@ -17,7 +17,7 @@
   test "wait_for_text waits for the page content regexp when no locator is provided" do
     client = Class.new { include Selenium::Client::Extensions }.new
     client.expects(:wait_for_condition).with(regexp_matches(%r{document.body.innerHTML.match\(/some text/\)}m), anything)
-    client.wait_for_text /some text/
+    client.wait_for_text(/some text/)
   end
 
   test "wait_for_text uses default timeout when none is provided" do
@@ -41,7 +41,7 @@
   test "wait_for_no_text waits for the page content for regexp when no locator is provided" do
     client = Class.new { include Selenium::Client::Extensions }.new
     client.expects(:wait_for_condition).with(regexp_matches(%r{document.body.innerHTML.match\(/some text/\)}m), anything)
-    client.wait_for_no_text /some text/
+    client.wait_for_no_text(/some text/)
   end
 
   test "wait_for_no_text waits for the page content when no locator is provided" do
@@ -154,4 +154,4 @@
     client.wait_for_no_field_value "a_locator", "a value", :timeout_in_seconds => :the_timeout
   end
 
-end
+end

test/unit/selenium/client/javascript_expression_builder_test.rb

@@ -57,8 +57,8 @@
 
   test "find_element adds a script to find an element" do
     builder = Selenium::Client::JavascriptExpressionBuilder.new
-    assert_match /element\s+=\s+selenium.browserbot.findElement\('a_locator'\);/m, 
-                 builder.find_element('a_locator').script
+    assert_match(/element\s+=\s+selenium.browserbot.findElement\('a_locator'\);/m, 
+                 builder.find_element('a_locator').script)
   end
 
   test "javascript_framework_for :prototype returns JavascriptFrameworks::Prototype" do
@@ -78,4 +78,4 @@
     assert_raises(RuntimeError) { builder.javascript_framework_for(:unsupported_framework) }
   end
 
-end
+end

test/unit/selenium/client/protocol_test.rb

@@ -4,20 +4,23 @@
 
   test "remote_control_command return the content of the HTTP response when the command succeeds" do
     client = Class.new { include Selenium::Client::Protocol }.new
+    client.instance_variable_set :@default_timeout_in_seconds, 1
     client.stubs(:http_request_for).with(:a_verb, :some_args).returns(:the_request)
     client.expects(:http_post).with(:the_request).returns(["OK", "the response"])
     assert_equal "the response", client.remote_control_command(:a_verb, :some_args)
   end
 
   test "remote_control_command raises a SeleniumCommandError when the command fails" do
     client = Class.new { include Selenium::Client::Protocol }.new
+    client.instance_variable_set :@default_timeout_in_seconds, 1
     client.stubs(:http_request_for).with(:a_verb, :some_args).returns(:the_request)
     client.expects(:http_post).with(:the_request).returns(["ERROR", "the error message"])
     assert_raises(SeleniumCommandError) { client.remote_control_command(:a_verb, :some_args) }
   end
 
   test "the args are optional for remote_control_command" do
     client = Class.new { include Selenium::Client::Protocol }.new
+    client.instance_variable_set :@default_timeout_in_seconds, 1
     client.expects(:http_request_for).with(:a_verb, []).returns(:the_request)
     client.stubs(:http_post).with(:the_request).returns(["OK", "the response"])
     client.remote_control_command(:a_verb)
@@ -124,4 +127,4 @@
     assert_equal "cmd=aCommand&1=This+%26+That", client.send(:http_request_for, "aCommand", [ "This & That" ])
   end
 
-end
+end