Fixing collision in example unique ids (RSpec reports)

Author: Philippe Hanrigou

README.markdown

@@ -38,7 +38,9 @@ Features
   * `click 'the_button_id', :wait_for => :element, :element => 'new_element_id'`
   * `click 'the_button_id', :wait_for => :no_element, :element => 'disappearing_element_id'`
   * `click 'the_button_id', :wait_for => :text, :text => 'New Text'`
+  * `click 'the_button_id', :wait_for => :text, :element => 'notification_box', :text => 'New Text'`
   * `click 'the_button_id', :wait_for => :no_text, :text => 'Disappearing Text'`
+  * `click 'the_button_id', :wait_for => :no_text, :element => 'notification_box', :text => 'Disappearing Text'`
   * `click 'the_button_id', :wait_for => :effects`
   * `click 'the_button_id', :wait_for => :condition, :javascript => "some arbitrary javascript expression"`
 

lib/selenium/rspec/reporting/file_path_strategy.rb

@@ -60,7 +60,9 @@ def file_path(relative_file_path)
         end
 
         def example_hash(example)
-          Digest::MD5.hexdigest example.backtrace.first
+          # backtrace is not reliable anymore using the implementation proc          
+          implementation = example.instance_variable_get :'@_implementation'
+          Digest::MD5.hexdigest implementation.inspect
         end
 
       end

test/unit/selenium/rspec/reporting/file_path_strategy_test.rb

@@ -14,19 +14,25 @@
     assert_equal File.expand_path("/another/dir"), second_strategy.base_report_dir
   end
 
-  test "example_hash is distinct when examples first backtrace entry is different" do
+  test "example_hash is distinct when examples implementation is different" do
     strategy = Selenium::RSpec::Reporting::FilePathStrategy.new "report.html"
 
-    first_example = stub('example',:backtrace => [ "a", "c" ])
-    second_example = stub('example',:backtrace => [ "b", "c" ])
+    first_example = Object.new
+    first_example.instance_variable_set :'@_implementation', Proc.new {}
+    second_example = Object.new
+    second_example.instance_variable_set :'@_implementation', Proc.new {}
+
     assert strategy.example_hash(first_example) != strategy.example_hash(second_example)
   end
 
-  test "example_hash is the same when examples first backtrace entry is identical" do
+  test "example_hash is the same when examples implementation is identical" do
     strategy = Selenium::RSpec::Reporting::FilePathStrategy.new "report.html"
-  
-    first_example = stub('example',:backtrace => [ "a", "b" ])
-    second_example = stub('example',:backtrace => [ "a", "c" ])
+
+    same_implementation = Proc.new {}  
+    first_example = Object.new
+    first_example.instance_variable_set :'@_implementation', same_implementation
+    second_example = Object.new
+    second_example.instance_variable_set :'@_implementation', same_implementation
     assert_equal strategy.example_hash(first_example), 
                  strategy.example_hash(second_example)
   end