Skip to content

Update Cargo.toml #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Cargo.toml #18

wants to merge 1 commit into from

Conversation

Dylan-DPC
Copy link

Bumps the dependency to at least 2.2.3 as per the advisory

Advisory

(even though this crate may not be using the function mentioned in the advisory, it is better to bump it to ensure that there is no chance of other dependencies pulling it)

@ankane
Copy link
Member

ankane commented May 20, 2025

Hi @Dylan-DPC, thanks for the PR. From what I can tell (testing w/ rust_decimal, which incorporated this in 1.37.0):

  • If an earlier version of Diesel is installed, this will pull in an earlier version of pgvector
  • If a later version of Diesel is installed, there is no change in behavior
  • If Diesel is not already installed, Cargo will pull in the latest version (no change in behavior)

Based on the above, it seems like this has a drawback without any benefit (but let me know if I missed something).

@ankane
Copy link
Member

ankane commented May 20, 2025

It looks like the benefit is dependent on how the dependency is specified in Cargo.toml.

rust_decimal = { version = "1", features = ["db-diesel2-postgres"] }

will pull in an earlier version of rust_decimal, while

rust_decimal = { version = "1.37", features = ["db-diesel2-postgres"] }

will upgrade diesel (or error if it can't be upgraded).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants