Merge branch 'master' into libpqxx8

Author: ankane

include/pgvector/halfvec.hpp

@@ -36,6 +36,7 @@ class HalfVector {
     }
 
     /// Creates a half vector from an array.
+    // TODO remove in 0.3.0
     HalfVector(const float* value, size_t n) {
         value_ = std::vector<float>{value, value + n};
     }

include/pgvector/pqxx.hpp

@@ -31,12 +31,14 @@ template <> struct string_traits<pgvector::Vector> {
             throw conversion_error("Malformed vector literal");
         }
 
-        // TODO don't copy string
         std::vector<float> result;
+        // TODO support empty array
+        // TODO don't copy string
         std::istringstream ss(std::string(text.substr(1, text.size() - 2)));
         while (ss.good()) {
             std::string substr;
             std::getline(ss, substr, ',');
+            // TODO use pqxx::from_string<float>
             result.push_back(std::stof(substr));
         }
         return pgvector::Vector(result);
@@ -66,12 +68,14 @@ template <> struct string_traits<pgvector::HalfVector> {
             throw conversion_error("Malformed halfvec literal");
         }
 
-        // TODO don't copy string
         std::vector<float> result;
+        // TODO support empty array
+        // TODO don't copy string
         std::istringstream ss(std::string(text.substr(1, text.size() - 2)));
         while (ss.good()) {
             std::string substr;
             std::getline(ss, substr, ',');
+            // TODO use pqxx::from_string<float>
             result.push_back(std::stof(substr));
         }
         return pgvector::HalfVector(result);

include/pgvector/vector.hpp

@@ -36,6 +36,7 @@ class Vector {
     }
 
     /// Creates a vector from an array.
+    // TODO remove in 0.3.0
     Vector(const float* value, size_t n) {
         value_ = std::vector<float>{value, value + n};
     }