test: expand realtime event tests for complete, fail, and run completion scenarios

- Updated SQL tests to increase plan counts and verify additional event behaviors
- Added checks to ensure no step:failed or run:completed events are sent in certain cases
- Improved validation of completed_at timestamps and payload contents across multiple tests
- Enhanced test coverage for realtime messaging logic in task completion, failure, and run
finalization

Author: jumski

pkgs/core/supabase/tests/realtime/complete_task_events.test.sql

@@ -1,5 +1,5 @@
 begin;
-select plan(7);
+select plan(9);
 
 -- Ensure partition exists for realtime.messages
 select pgflow_tests.create_realtime_partition();
@@ -48,14 +48,14 @@ select is(
 
 -- Test 4: Verify completed_at timestamp exists and is valid
 select ok(
-  (select (payload->>'completed_at')::timestamptz is not null 
+  (select (payload->>'completed_at')::timestamptz is not null
    from pgflow_tests.get_realtime_message('step:completed', (select run_id from run_ids), 'first')),
   'The step:completed event should include a completed_at timestamp'
 );
 
 -- Test 5: Verify output data is included in payload
 select is(
-  (select payload->'output'->>'result' 
+  (select payload->'output'->>'result'
    from pgflow_tests.get_realtime_message('step:completed', (select run_id from run_ids), 'first')),
   'success',
   'The step:completed event should contain the correct output data'
@@ -75,6 +75,20 @@ select is(
   'The step:completed event should have the correct topic (pgflow:run:<run_id>)'
 );
 
+-- Test 8: Verify no step:failed events were sent for the completed step
+select is(
+  pgflow_tests.count_realtime_events('step:failed', (select run_id from run_ids), 'first'),
+  0::int,
+  'pgflow.complete_task should NOT send any step:failed events'
+);
+
+-- Test 9: Verify no run:completed event was sent (since there are more steps to complete)
+select is(
+  pgflow_tests.count_realtime_events('run:completed', (select run_id from run_ids)),
+  0::int,
+  'pgflow.complete_task should NOT send run:completed event when steps remain incomplete'
+);
+
 -- Clean up
 drop table if exists run_ids;
 drop table if exists completed_tasks;

pkgs/core/supabase/tests/realtime/fail_task_events.test.sql

@@ -1,5 +1,5 @@
 begin;
-select plan(3);
+select plan(5);
 
 -- Ensure partition exists for realtime.messages
 select pgflow_tests.create_realtime_partition();
@@ -47,6 +47,20 @@ select is(
   'The run:failed event should have the correct topic (pgflow:run:<run_id>)'
 );
 
+-- Test 4: Verify no step:completed events were sent for the failed step
+select is(
+  pgflow_tests.count_realtime_events('step:completed', (select run_id from run_ids), 'first'),
+  0::int,
+  'pgflow.fail_task should NOT send any step:completed events for the failed step'
+);
+
+-- Test 5: Verify no run:completed events were sent
+select is(
+  pgflow_tests.count_realtime_events('run:completed', (select run_id from run_ids)),
+  0::int,
+  'pgflow.fail_task should NOT send any run:completed events when a run fails'
+);
+
 -- Clean up
 drop table if exists run_ids;
 drop table if exists failed_tasks;

pkgs/core/supabase/tests/realtime/maybe_complete_run_events.test.sql

@@ -1,5 +1,5 @@
 begin;
-select plan(5);
+select plan(6);
 
 -- Ensure partition exists for realtime.messages
 select pgflow_tests.create_realtime_partition();
@@ -50,7 +50,7 @@ select is(
 
 -- Test 4: Verify completed_at timestamp exists and is valid
 select ok(
-  (select (payload->>'completed_at')::timestamptz is not null 
+  (select (payload->>'completed_at')::timestamptz is not null
    from pgflow_tests.get_realtime_message('run:completed', (select run_id from run_ids))),
   'The run:completed event should include a completed_at timestamp'
 );
@@ -62,6 +62,13 @@ select is(
   'The run:completed event should have the correct topic (pgflow:run:<run_id>)'
 );
 
+-- Test 6: Verify no run:failed events were sent
+select is(
+  pgflow_tests.count_realtime_events('run:failed', (select run_id from run_ids)),
+  0::int,
+  'pgflow.maybe_complete_run should NOT send any run:failed events on successful completion'
+);
+
 -- Clean up
 drop table if exists run_ids;
 drop table if exists completed_tasks;