Allow sloped/transform shape with non-identity transformation #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies the fixes of thinbold and muzimuzhi also to curves and lines while not globalize xc/yc for the line. Co-Authored-By: Yukai Chou <6376638+muzimuzhi@users.noreply.github.com> Co-Authored-By: Thin Bold <48164818+thinbold@users.noreply.github.com>
Co-Authored-By: Yukai Chou <6376638+muzimuzhi@users.noreply.github.com> Co-Authored-By: Thin Bold <48164818+thinbold@users.noreply.github.com>
This applies the fixes of thinbold and muzimuzhi also to curves and lines while not globalize xc/yc for the line. Co-Authored-By: Yukai Chou <6376638+muzimuzhi@users.noreply.github.com> Co-Authored-By: Thin Bold <48164818+thinbold@users.noreply.github.com> Signed-off-by: Qrrbrbirlbel <qrrbrbirlbel+github@gmail.com>
Co-Authored-By: Yukai Chou <6376638+muzimuzhi@users.noreply.github.com> Co-Authored-By: Thin Bold <48164818+thinbold@users.noreply.github.com> Signed-off-by: Qrrbrbirlbel <qrrbrbirlbel+github@gmail.com>
Signed-off-by: Qrrbrbirlbel <qrrbrbirlbel+github@gmail.com> Signoff Signed-off-by: Qrrbrbirlbel <qrrbrbirlbel+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the fixes of @thinbold and @muzimuzhi also to curves and arc while not globalize xc/yc for the line function.
In my opinion, this is not a breaking change because the previous behavior was never the intended way.
This is a redo of #1287 because I'm fighting with GitHub.
Motivation for this change
Fixes #1058
Checklist
Please signoff your commits to explicitly state your agreement to the Developer Certificate of Origin. If that is not possible you may check the boxes below instead: