Remove deprecated pgr create vertices table v4.0

[cvvergara]

Fixes #2827 .

Removes:

• SQL files
• pgtap files, not testing a deprecated function
• docqueries files
• documentation files

@pgRouting/admins

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cvvergara]

@coderabbitai summary
@coderabbitai review

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

I need to gather information about this pull request before I can generate a summary and review. Let me do that now.

---

🏁 Script executed:

#!/bin/bash
# Get information about the pull request
echo "Pull Request Information:"
gh pr view 2841 --json title,body,additions,deletions,changedFiles,baseRefName,headRefName,state,url

# List the files changed in the PR
echo -e "\nFiles Changed:"
gh pr view 2841 --json files --jq '.files[].path'

# Get details about the repository
echo -e "\nRepository Information:"
gh repo view --json name,description,defaultBranchRef

Length of output: 1854

---

Let me gather more information about the specific changes in this PR to provide an accurate summary and review.

---

🏁 Script executed:

#!/bin/bash
# Check the issue being fixed
echo "Issue #2827 details:"
gh issue view 2827 --json title,body

# Check the NEWS.md changes
echo -e "\nNEWS.md changes:"
gh pr view 2841 --json files --jq '.files[] | select(.path == "NEWS.md") | .patch'

# Check one of the key files being removed
echo -e "\nSQL file being removed:"
cat sql/topology/createverticestable.sql

# Check CMakeLists.txt changes
echo -e "\nCMakeLists.txt changes:"
gh pr view 2841 --json files --jq '.files[] | select(.path == "sql/topology/CMakeLists.txt") | .patch'

Length of output: 976

---

I need more information about the changes in this PR to provide a proper summary and review. Let me continue gathering data.

---

🏁 Script executed:

#!/bin/bash
# Check for the NEWS.md changes with the correct diff format
echo "NEWS.md changes:"
git diff --no-index origin/develop...HEAD NEWS.md || echo "Could not get diff, trying another approach"
gh pr diff 2841 | grep -A 10 NEWS.md

# Check the sig file changes
echo -e "\nsig file changes:"
gh pr diff 2841 | grep -A 20 "sql/sigs/pgrouting--4.0.sig"

# Check release notes changes
echo -e "\nRelease notes changes:"
gh pr diff 2841 | grep -A 20 "doc/src/release_notes.rst"

# Try to look at the content of the SQL file in the base branch
echo -e "\nSQL file content in base branch:"
git show origin/develop:sql/topology/createverticestable.sql || echo "File not found in base branch"

# Check pgrouting version info
echo -e "\nVersion info:"
git grep -A 10 "project(" CMakeLists.txt

Length of output: 3528

---

Let me get more information about the specific file content and PR details to provide a proper summary and review.

---

🏁 Script executed:

#!/bin/bash
# Get the PR diff to see the content of the removed file
echo "PR diff excerpt showing removed SQL file content:"
gh pr diff 2841 | grep -A 50 "sql/topology/createverticestable.sql"

# Try to fetch the file from the PR branch
echo -e "\nTrying to get the PR branch:"
gh pr checkout 2841
git branch --show-current

# Check changes to topology-functions.rst
echo -e "\nTopology functions documentation changes:"
git diff HEAD~1 doc/topology/topology-functions.rst | head -30

# List all changed files with status
echo -e "\nAll changed files with status:"
git status -s

Length of output: 2988

---

@cvvergara

PR Summary

This PR removes the deprecated pgr_createVerticesTable function and all associated files from the codebase as part of the 4.0.0 release. The function was originally introduced in v2.0.0, deprecated in v3.8.0, and is now being removed as planned.

The PR:

• Removes the SQL implementation in createverticestable.sql
• Removes documentation, pgtap tests, and docqueries
• Updates function signatures and build configuration files
• Updates NEWS.md and release notes to document the removal

The function was deprecated because it used predefined names for database objects, required higher permissions, and has been superseded by pgr_extractVertices which gives users more control.

Review

The changes look appropriate and well-executed:

✅ All references to the deprecated function have been removed from the codebase
✅ Documentation has been updated to reflect the removal
✅ Release notes and NEWS.md have been properly updated with the issue reference
✅ The PR follows the planned deprecation cycle outlined in issue #2827

The removal is properly documented in both the NEWS.md and release_notes.rst files with a reference to issue #2827. All tests, documentation, and implementation files have been removed, which is appropriate for a complete deprecation.

No issues found - this PR is ready to merge.