diff --git a/security/pfSense-pkg-snort/Makefile b/security/pfSense-pkg-snort/Makefile index a826a26ba137..73662c6eee4a 100644 --- a/security/pfSense-pkg-snort/Makefile +++ b/security/pfSense-pkg-snort/Makefile @@ -2,7 +2,7 @@ PORTNAME= pfSense-pkg-snort PORTVERSION= 4.0 -PORTREVISION= 3 +PORTREVISION= 4 CATEGORIES= security MASTER_SITES= # empty DISTFILES= # empty diff --git a/security/pfSense-pkg-snort/files/usr/local/pkg/snort/snort_check_for_rule_updates.php b/security/pfSense-pkg-snort/files/usr/local/pkg/snort/snort_check_for_rule_updates.php index c110584d8272..0d06b6dd3ff2 100644 --- a/security/pfSense-pkg-snort/files/usr/local/pkg/snort/snort_check_for_rule_updates.php +++ b/security/pfSense-pkg-snort/files/usr/local/pkg/snort/snort_check_for_rule_updates.php @@ -825,5 +825,4 @@ function snort_apply_customizations($snortcfg, $if_real) { else $config['installedpackages']['snortglobal']['last_rule_upd_status'] = gettext("success"); $config['installedpackages']['snortglobal']['last_rule_upd_time'] = time(); -write_config("Snort pkg: updated status for updated rules package(s) check.", FALSE); ?> diff --git a/security/pfSense-pkg-snort/files/usr/local/www/snort/snort_interface_logs.php b/security/pfSense-pkg-snort/files/usr/local/www/snort/snort_interface_logs.php index 6f96fc4e5235..883dd372aa1a 100644 --- a/security/pfSense-pkg-snort/files/usr/local/www/snort/snort_interface_logs.php +++ b/security/pfSense-pkg-snort/files/usr/local/www/snort/snort_interface_logs.php @@ -3,11 +3,11 @@ * snort_interface_logs.php * * part of pfSense (https://www.pfsense.org) - * Copyright (c) 2006-2018 Rubicon Communications, LLC (Netgate) + * Copyright (c) 2006-2019 Rubicon Communications, LLC (Netgate) * Copyright (c) 2005 Bill Marquette . * Copyright (c) 2003-2004 Manuel Kasper . * Copyright (c) 2009 Robert Zelaya Sr. Developer - * Copyright (c) 2014-2018 Bill Meeks + * Copyright (c) 2014-2019 Bill Meeks * All rights reserved. * * Licensed under the Apache License, Version 2.0 (the "License"); @@ -43,8 +43,8 @@ // Construct a pointer to the instance's logging subdirectory $snortlogdir = SNORTLOGDIR . "/snort_{$if_real}{$snort_uuid}/"; -// Construct a pointer to the PBI_BIN directory -$snortbindir = SNORT_PBI_BINDIR; +// Construct a pointer to the Snort BIN directory +$snortbindir = SNORT_BINDIR; // Limit all file access to just the currently selected interface's logging subdirectory $logfile = htmlspecialchars($snortlogdir . basename($_POST['file'])); diff --git a/security/pfSense-pkg-snort/files/usr/local/www/snort/snort_interfaces_global.php b/security/pfSense-pkg-snort/files/usr/local/www/snort/snort_interfaces_global.php index bec305fd1b40..547fe8fd5f02 100644 --- a/security/pfSense-pkg-snort/files/usr/local/www/snort/snort_interfaces_global.php +++ b/security/pfSense-pkg-snort/files/usr/local/www/snort/snort_interfaces_global.php @@ -35,13 +35,13 @@ $pconfig = $_POST; else { $pconfig['snortdownload'] = $config['installedpackages']['snortglobal']['snortdownload'] == "on" ? 'on' : 'off'; - $pconfig['oinkmastercode'] = $config['installedpackages']['snortglobal']['oinkmastercode']; - $pconfig['etpro_code'] = $config['installedpackages']['snortglobal']['etpro_code']; + $pconfig['oinkmastercode'] = htmlentities($config['installedpackages']['snortglobal']['oinkmastercode']); + $pconfig['etpro_code'] = htmlentities($config['installedpackages']['snortglobal']['etpro_code']); $pconfig['emergingthreats'] = $config['installedpackages']['snortglobal']['emergingthreats'] == "on" ? 'on' : 'off'; $pconfig['emergingthreats_pro'] = $config['installedpackages']['snortglobal']['emergingthreats_pro'] == "on" ? 'on' : 'off'; $pconfig['rm_blocked'] = $config['installedpackages']['snortglobal']['rm_blocked']; $pconfig['autorulesupdate7'] = $config['installedpackages']['snortglobal']['autorulesupdate7']; - $pconfig['rule_update_starttime'] = $config['installedpackages']['snortglobal']['rule_update_starttime']; + $pconfig['rule_update_starttime'] = htmlentities($config['installedpackages']['snortglobal']['rule_update_starttime']); $pconfig['forcekeepsettings'] = $config['installedpackages']['snortglobal']['forcekeepsettings'] == "on" ? 'on' : 'off'; $pconfig['snortcommunityrules'] = $config['installedpackages']['snortglobal']['snortcommunityrules'] == "on" ? 'on' : 'off'; $pconfig['clearblocks'] = $config['installedpackages']['snortglobal']['clearblocks'] == "on" ? 'on' : 'off'; @@ -141,8 +141,8 @@ snort_remove_dead_rules(); } - $config['installedpackages']['snortglobal']['oinkmastercode'] = $_POST['oinkmastercode']; - $config['installedpackages']['snortglobal']['etpro_code'] = $_POST['etpro_code']; + $config['installedpackages']['snortglobal']['oinkmastercode'] = trim(html_entity_decode($_POST['oinkmastercode'])); + $config['installedpackages']['snortglobal']['etpro_code'] = trim(html_entity_decode($_POST['etpro_code'])); $config['installedpackages']['snortglobal']['rm_blocked'] = $_POST['rm_blocked']; $config['installedpackages']['snortglobal']['autorulesupdate7'] = $_POST['autorulesupdate7']; @@ -154,7 +154,7 @@ $tmp = str_pad($_POST['rule_update_starttime'], 4, "0", STR_PAD_LEFT); $_POST['rule_update_starttime'] = substr($tmp, 0, 2) . ":" . substr($tmp, -2); } - $config['installedpackages']['snortglobal']['rule_update_starttime'] = str_pad($_POST['rule_update_starttime'], 4, "0", STR_PAD_LEFT); + $config['installedpackages']['snortglobal']['rule_update_starttime'] = str_pad(html_entity_decode($_POST['rule_update_starttime']), 4, "0", STR_PAD_LEFT); } $config['installedpackages']['snortglobal']['forcekeepsettings'] = $_POST['forcekeepsettings'] ? 'on' : 'off'; diff --git a/security/pfSense-pkg-snort/files/usr/local/www/snort/snort_rules.php b/security/pfSense-pkg-snort/files/usr/local/www/snort/snort_rules.php index 0b302105363b..dde33615d169 100644 --- a/security/pfSense-pkg-snort/files/usr/local/www/snort/snort_rules.php +++ b/security/pfSense-pkg-snort/files/usr/local/www/snort/snort_rules.php @@ -27,7 +27,7 @@ global $g, $rebuild_rules; $snortdir = SNORTDIR; -$snortbindir = SNORT_PBI_BINDIR; +$snortbindir = SNORT_BINDIR; $rules_map = array(); $categories = array(); $pconfig = array();