Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isort does not recognize first party correctly #36

Open
drafear opened this issue May 10, 2023 · 1 comment · May be fixed by #37
Open

isort does not recognize first party correctly #36

drafear opened this issue May 10, 2023 · 1 comment · May be fixed by #37

Comments

@drafear
Copy link
Member

drafear commented May 10, 2023

Although isort recognizes first party under settings file, isort is called with config file under /tmp/ in pysen.
So, the results of pysen run format and pysen generate && isort --settings-file=pyproject.toml . differs.
@drafear
Copy link
Member Author

drafear commented May 10, 2023 •
edited
Loading

I'm not confident, but --src . option will solve it.

@drafear drafear linked a pull request May 10, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix isort_wrapper to recognize first party correctly drafear/pysen
1 participant
@drafear