-
-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GroupedVirtuoso is crashing when trying to rerender component #83
Comments
This is a head-scratcher. So far, I have attributed this to StackBlitz hot reload mechanism. Will look into it, but if you can give me an easier way to reproduce it, it would help a lot. Cheers, |
@petyosi ok, I'll try to provide normal example later today or tomorrow |
Just a quick update: I tried reproducing the issue in the clone of react-virtuoso repository with no luck. It doesn't seem to like empty list passed to it, but that seems to be a separate story. On our side we're able to reproduce the issue by simply rendering I tried debugging it a bit and it looks like
when it fails it looks like this:
I know it's not much to go on - we'll try to find a better way to reproduce it tomorrow. |
@petyosi I found a clear way to reproduce the issue: Just keep pressing "Show/Hide" button until the list disappears from the screen and it says "Hidden" instead. You should see the exception in the console at that point. Ignore the fact that sizes of items keep changing randomly - we're not doing that crazy stuff in our code. The culprit seems to be related to the fact that How can we solve this? |
Thanks, I will repro the problem and release a fix - it should not be something to fix on your side. |
Could you tell us when you're planning to make the release? |
I will look into it this evening, and if something easy, I might release a fix for tomorrow. If not, I will have to examine it over the weekend. |
I found one possible cause - can you test v0.14.1? |
I seem to be unable to reproduce the issue. I'll give the build to QA in the morning to make sure it's solid. Thanks again! |
It seems to be fine now. Amazing! |
We have component, which uses
GroupedVirtuoso
. Some state of our component is changed, which leads to call ofrender()
function. As a result we have exception inGroupedVirtuoso
:Requested offset outside of the known ones, index: 0
I am 110% sure, that data, which is passed to
GroupedVirtuoso
component is correct.In fact, i was able to reproduce issue with an example from
Virtuoso
official page.I'm not good in web, so sorry in advance, why i did not provide a working example.
return()
(15th line) add this:console.log("wassup");
So, thing is, that we are getting such exception every time, when state of the component is modified, even if data, which is passed to
GroupedVirtuoso
was not changed.May be there are some workaround for this issue? Using simple
VirtuosoList
is not an option: we need those sticky headers.Thanks.
The text was updated successfully, but these errors were encountered: