Prevent double disk caching when SDWebImageRefreshCached option is used SDWebImage#326

Olivier Poitrey · Olivier Poitrey · commit a3e3c61d463f · 2013-03-12T14:55:29.000+01:00
diff --git a/SDWebImage/SDWebImageManager.m b/SDWebImage/SDWebImageManager.m
@@ -129,7 +129,14 @@ - (NSString *)cacheKeyForURL:(NSURL *)url
                 }
                 else
                 {
-                    const BOOL cacheOnDisk = !(options & SDWebImageCacheMemoryOnly);
+                    BOOL cacheOnDisk = !(options & SDWebImageCacheMemoryOnly);
+
+                    if (options & SDWebImageRefreshCached)
+                    {
+                        // When SDWebImageRefreshCached option is enabled, the disk caching relies on NSURLCache one.
+                        // We thus fork SDWebImage cache to be disabled so we don't duplicate the required storage space for nothing.
+                        cacheOnDisk = NO;
+                    }
 
                     if (downloadedImage && [self.delegate respondsToSelector:@selector(imageManager:transformDownloadedImage:withURL:)])
                     {

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,14 @@ - (NSString )cacheKeyForURL:(NSURL )url`
`129`	`129`	`}`
`130`	`130`	`else`
`131`	`131`	`{`
`132`		`- const BOOL cacheOnDisk = !(options & SDWebImageCacheMemoryOnly);`
	`132`	`+ BOOL cacheOnDisk = !(options & SDWebImageCacheMemoryOnly);`
	`133`	`+`
	`134`	`+ if (options & SDWebImageRefreshCached)`
	`135`	`+ {`
	`136`	`+ // When SDWebImageRefreshCached option is enabled, the disk caching relies on NSURLCache one.`
	`137`	`+ // We thus fork SDWebImage cache to be disabled so we don't duplicate the required storage space for nothing.`
	`138`	`+ cacheOnDisk = NO;`
	`139`	`+ }`
`133`	`140`
`134`	`141`	`if (downloadedImage && [self.delegate respondsToSelector:@selector(imageManager:transformDownloadedImage:withURL:)])`
`135`	`142`	`{`