refactor: pipelines switched to native shell pipelines

Author: petrknap

src/Filter.php

@@ -46,14 +46,15 @@ public function filter(mixed $input, mixed $output = null, mixed $error = null):
             };
         }
 
-        $process = $this->startFilter($input, static function (string $type, string $data) use ($output, $error): void {
+        $process = Process::fromShellCommandline($this->buildShellCommandLine());
+        $process->setInput($input);
+        $process->run(static function (string $type, string $data) use ($output, $error): void {
             /** @var Process::OUT|Process::ERR $type */
             match ($type) {
                 Process::OUT => $output === null or fwrite($output, $data),
                 Process::ERR => $error === null or fwrite($error, $data),
             };
         });
-        $process->wait();
         if (!$process->isSuccessful()) {
             throw new class ($process) extends ProcessFailedException implements Exception\FilterException {
             };
@@ -80,22 +81,12 @@ public function pipe(self $to): self
         return $base;
     }
 
-    /**
-     * @param string|resource $input
-     */
-    private function startFilter(mixed $input, callable|null $callback): Process
+    private function buildShellCommandLine(): string
     {
-        if ($this->previous !== null) {
-            $input = $this->previous->startFilter($input, null);
-        }
-
-        $process = new Process([
-            $this->command,
-            ...$this->options,
-        ]);
-        $process->setInput($input);
-        $process->start($callback);
-
-        return $process;
+        return ($this->previous === null ? '' : "{$this->previous->buildShellCommandLine()} | ")
+            . (new Process([
+                $this->command,
+                ...$this->options,
+            ]))->getCommandLine();
     }
 }

tests/FilterTest.php

@@ -9,7 +9,6 @@
 use PetrKnap\Profiler\ProfilerInterface;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Depends;
-use PHPUnit\Framework\ExpectationFailedException;
 use PHPUnit\Framework\TestCase;
 use stdClass;
 use Symfony\Component\Process\Process;
@@ -104,7 +103,7 @@ public function testPipelineDoesNotHaveMemoryLeak(ProfileInterface $profile): vo
         [$referenceProfile, $pipelineProfile] = $profile->getChildren();
 
         self::assertLessThanOrEqual(
-            $referenceProfile->getMemoryUsageChange() * 1.05,  # allow 5% overhead
+            $referenceProfile->getMemoryUsageChange() * 1.1,  # allow 10% overhead
             $pipelineProfile->getMemoryUsageChange(),
         );
 
@@ -117,14 +116,11 @@ public function testPipelineDoesNotHaveMemoryLeak(ProfileInterface $profile): vo
     public function testPipelinePerformanceIsOk(ProfileInterface $profile): void
     {
         [$referenceProfile, $pipelineProfile] = $profile->getChildren();
-        try {  # @todo fix performance and remove try / catch
-            self::assertLessThanOrEqual(
-                $referenceProfile->getDuration() * 1.05,  # allow 5% overhead
-                $pipelineProfile->getDuration(),
-            );
-        } catch (ExpectationFailedException $expectationFailed) {
-            self::markTestIncomplete($expectationFailed->getMessage());
-        }
+
+        self::assertLessThanOrEqual(
+            $referenceProfile->getDuration() * 1.1,  # allow 10% overhead
+            $pipelineProfile->getDuration(),
+        );
     }
 
     #[DataProvider('dataThrows')]