[NAB-388] HTML code in i18String tag is sanitized on export #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-export i18n as cdata section and import it same way
mazarijuraj
requested changes
Oct 24, 2025
Contributor
mazarijuraj
left a comment
mazarijuraj
left a comment
There was a problem hiding this comment.
Update test model petriflow_test.xml and 'should import & export' in petriflow.spec.js to test that i18n with html code is correctly imported and exported
-add cdata to test file to i18ns and add it to test
mazarijuraj
reviewed
Oct 29, 2025
| </data> | ||
| <data type="text"> | ||
| <id>newVariable_22</id> | ||
| <title>HTML no translation</title> |
Contributor
There was a problem hiding this comment.
Deceptive title, this HTML area has translations ...
src/test/petriflow.spec.js
Outdated
| expect(i18nLocale.getI18n(i)).not.toBeUndefined(); | ||
| expect(i18nLocale.getI18n(i).value).toEqual(`${locale.toUpperCase()}_${i}`); | ||
| }); | ||
| expect(i18nLocale.getI18n(TEST_HTML).value).toEqual(`<h2>${locale.toUpperCase()}_Title</h2>`) |
Contributor
There was a problem hiding this comment.
Better way would be to add another list as argument that would be ids of i18ns that should match not by .toEqaul() but by contains. This way you could simply put:
expect(i18nLocale.getI18ns().length).toEqual(i18ns_equal.length + i18ns_contain.length);
...
i18ns_equal.forEach( ... );
i18ns_contain.forEach( ... );
src/test/petriflow.spec.js
Outdated
| function assertI18n(locale, i18ns, model) { | ||
| const i18nLocale = model.getI18n(locale); | ||
| expect(i18nLocale.getI18ns().length).toEqual(i18ns.length); | ||
| expect(i18nLocale.getI18ns().length).toEqual(i18ns.length + 1); |
Contributor
There was a problem hiding this comment.
This +1 has very poor readability. See the next comment for better solution
- fixes according to PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-export i18n as cdata section and import it same way
Fixes [NAB-388]
Dependencies
none
Third party dependencies
Blocking Pull requests
There are no dependencies on other PR
How Has Been This Tested?
manually
Test Configuration
<Please describe configuration for tests to run if applicable, like program parameters, host OS, VM configuration etc.>
Checklist: