Use ExtensionsManager.lookupExtensionSettingsById when verifying extension unique id (opensearch-project#2749)

cwperks · web-flow · commit 9d758f9166e6 · 2023-05-09T23:31:35.000-07:00
Signed-off-by: Craig Perkins &lt;cwperx@amazon.com&gt;
diff --git a/src/main/java/org/opensearch/security/transport/SecurityRequestHandler.java b/src/main/java/org/opensearch/security/transport/SecurityRequestHandler.java
@@ -338,7 +338,7 @@ protected void addAdditionalContextValues(final String action, final TransportRe
         String extensionUniqueId = getThreadContext().getHeader("extension_unique_id");
         if (extensionUniqueId != null) {
             ExtensionsManager extManager = OpenSearchSecurityPlugin.GuiceHolder.getExtensionsManager();
-            if (extManager.lookupInitializedExtensionById(extensionUniqueId).isPresent()) {
+            if (extManager.lookupExtensionSettingsById(extensionUniqueId).isPresent()) {
                 getThreadContext().putTransient(ConfigConstants.OPENDISTRO_SECURITY_SSL_TRANSPORT_EXTENSION_REQUEST, Boolean.TRUE);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -338,7 +338,7 @@ protected void addAdditionalContextValues(final String action, final TransportRe`
`338`	`338`	`String extensionUniqueId = getThreadContext().getHeader("extension_unique_id");`
`339`	`339`	`if (extensionUniqueId != null) {`
`340`	`340`	`ExtensionsManager extManager = OpenSearchSecurityPlugin.GuiceHolder.getExtensionsManager();`
`341`		`- if (extManager.lookupInitializedExtensionById(extensionUniqueId).isPresent()) {`
	`341`	`+ if (extManager.lookupExtensionSettingsById(extensionUniqueId).isPresent()) {`
`342`	`342`	`getThreadContext().putTransient(ConfigConstants.OPENDISTRO_SECURITY_SSL_TRANSPORT_EXTENSION_REQUEST, Boolean.TRUE);`
`343`	`343`	`}`
`344`	`344`	`}`