Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Julia version Compat #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

PaulDebus
Copy link
Collaborator

Increase lowest supported Julia version to 1.6
Set Compatibility to ^1.6 so anything <2 works
Update the CI to use Julia 1.6 instead of 1.4

Should this trigger a new release of this package? I would wait until we sort out #37 and #38

Increase lowest supported Julia version to 1.6
Set Compatibility to ^1.6 so anything <2 works
Update the CI to use Julia 1.6 instead of 1.4
@PaulDebus PaulDebus requested a review from nlw0 July 26, 2023 10:11
@PaulDebus PaulDebus self-assigned this Jul 26, 2023
@nlw0
Copy link
Collaborator

nlw0 commented Jul 26, 2023

It's a good question about the version, according to semver.org we should mostly focus on whether there were changes to the API... I propose we call this a bug and just upgrade the patch version.

I noticed tests seem to be running on windows but not linux. Maybe just a different version of PyPlot can solve it? I can't tell which specified versions of the other packages are relevant as well... Perhaps we could give it a try to upgrade all of them?

@PaulDebus
Copy link
Collaborator Author

Yeah, increasing the patch version sounds fine to me.
Regarding the test failing on ubuntu: I looked into it and it looks like the error is also occuring in PyPlot
JuliaPy/PyPlot.jl#571
I see two options: wait for them to figure out the issue and the solution should propagate to us or we cut the old ties, set the minimum version to 1.9, move PyPlot into a weak dependency and call it a day. What do you think?

@PaulDebus
Copy link
Collaborator Author

A general look at the dependencies and updating the incompatibilities is also a good idea, although not directly related here IMHO. This should be a separate cleanup step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants