Skip to content

add colorize #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add colorize #10

wants to merge 2 commits into from

Conversation

daddygongon
Copy link

What a fantastic idea!
I will use this in my class since next Wednesday after changing the text.
Would you add the 'color' for 'red, green, refactoring' ?
While this makes the codes dirty, I usually teach students "Color makes things simpler"

@peterc
Copy link
Owner

peterc commented Oct 7, 2019

There is another PR under review which changes the layout of these methods, so we might need to hold this one back until that's sorted out, but I do like your idea!

However, one change I will need to make is to make this an optional feature which depends upon whether colorize is installed or not. I don't want testrocket to force anyone into extra dependencies, but if colorize is installed, I am happy for it to be used :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants