Add rebuild command #90
Conversation
| :type => :boolean, | ||
| :aliases => "-c", | ||
| :desc => "Skip confirmation of the action" | ||
| method_option "imageId", |
There was a problem hiding this comment.
Can we do image_id to keep it consistent with the other CLI methods?
|
Nice! A couple thoughts on the method option stuff from the CLI, but this looks really great. One major thing is that there aren't any tests. We do have tests on the rest of the CLI (see the Let me know if you're having trouble with the tests, I can definitely help out. Thanks a ton! |
|
Let me have a look at the tests. I have committed some basic test. I hope there enough coverage as there are many combinaisons… |
|
I have since had to create 2 more commands destroy_image and info_image do you want me to roll it in one pull request or do you prefer to deal with one after the other? |
|
@PierreFrisch We should probably keep them separate to make it easier. This looks great! I'm going to merge it in. |
|
Thank you! Feel free to open PRs for the other stuff. :) |
I needed to add the rebuild command. I have also added the fuzzy detection of the image.