This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
New feature: resizing existing swapfiles #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@acjohnson here's a working implementation with stringify_facts false, I've got a CSV fact for getting it to work on older Puppet, let me try and fix that now 👍 |
petems
force-pushed
the
allow_resizing_of_swapfiles
branch
from
2851f55
to
36ab379
Compare
|
Awesome, so two different facts depending on how stringify is configured. Cool, is this working then? I'll test it if you think it's ready to test. |
|
@acjohnson I haven't quite got the non-stringify_facts part of it working yet, but I'm going to probably merge the stringify_facts false version to get the basics down, then get an acceptance test for hte other path and get the other version working 👍 |
petems
force-pushed
the
allow_resizing_of_swapfiles
branch
13 times, most recently
from
60099a4
to
c403a66
Compare
petems
force-pushed
the
allow_resizing_of_swapfiles
branch
from
c403a66
to
4756a67
Compare
* Inspired by the work by @acjohnson * Uses the $::swapfile_sizes fact as a hash * Checks if a swapfile already exists * If it does, compares sizes * If the size differs over the margin given (defaulting to 50MB) then `swapoff` the swap and deletes it * The reason we have a margin is... * The to_bytes method uses layman math for MB: 1 MB = 1024 KB, when in fact 1 MB = 1000 KB, and 1 MiB = 1024 KiB. * Adding a `before` to the Exec means that it ensure's it'll get made before it. * Adds a some specific functions to get a difference with margin * Cleaner than having to do (max($arg1, $arg2) - min($arg1,$arg2) - $margin) * This approach currently doesn't work for `stringify_facts` is true, because the hash of swap files gets turned into a string. * Right now this will error out, but I'm going to make a function to make a CSV fact for the future!
petems
force-pushed
the
allow_resizing_of_swapfiles
branch
from
4756a67
to
fd0d8a2
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swap offthe swap and deletes itbeforeto the Exec means that it ensure's it'll get made before it.