Use correct constant to read 64bit registry #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
reviewed
Jun 16, 2022
Comment on lines
+1670
to
+1672
| #ifndef RRF_SUBKEY_WOW6464KEY | ||
| # define RRF_SUBKEY_WOW6464KEY 0x00010000 | ||
| #endif |
There was a problem hiding this comment.
Could you please move the preprocessor definitions to the top of the file, where all the other constants are defined? Thanks!
tonycoz
added a commit
to tonycoz/perl5
that referenced
this pull request
Jul 11, 2024
perl-libwin32/win32#37 was submitted ih June 2022, and fixes a bug that causes tests to fail for Win32.pm for 32-bit builds on windows, including in perl (and in 5.40.) Jan requested a minor change to that PR which wasn't followed up on, so I submitted perl-libwin32/win32#39 which includes that requested change in Augest 2023. This still has been acted on. So import this change into blead.
tonycoz
added a commit
to tonycoz/perl5
that referenced
this pull request
Jul 11, 2024
perl-libwin32/win32#37 was submitted ih June 2022, and fixes a bug that causes tests to fail for Win32.pm for 32-bit builds on windows, including in perl (and in 5.40.) Jan requested a minor change to that PR which wasn't followed up on, so I submitted perl-libwin32/win32#39 which includes that requested change in August 2023. This still hasn't been acted on. So import this change into blead.
tonycoz
added a commit
to tonycoz/perl5
that referenced
this pull request
Jul 11, 2024
perl-libwin32/win32#37 was submitted in June 2022, it fixes a bug that causes tests to fail for Win32.pm for 32-bit builds on windows, including in perl (and in 5.40.) Jan requested a minor change to that PR which wasn't followed up on, so I submitted perl-libwin32/win32#39 which includes that requested change in August 2023. This still hasn't been acted on. So import this change into blead.
tonycoz
added a commit
to Perl/perl5
that referenced
this pull request
Jul 17, 2024
perl-libwin32/win32#37 was submitted in June 2022, it fixes a bug that causes tests to fail for Win32.pm for 32-bit builds on windows, including in perl (and in 5.40.) Jan requested a minor change to that PR which wasn't followed up on, so I submitted perl-libwin32/win32#39 which includes that requested change in August 2023. This still hasn't been acted on. So import this change into blead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #36