-
Notifications
You must be signed in to change notification settings - Fork 9
Update COPYRIGHT #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update COPYRIGHT #317
Conversation
Need to modify the existing license to include the portions of code unique to Percona.
@shoffman-percona for now And 99% of our work is in that folder, we made very little changes to the postgres server itself. Should we keep that? |
Fixed quotes
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (80.28%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #317 +/- ##
=====================================================
- Coverage 80.29% 80.28% -0.01%
=====================================================
Files 22 22
Lines 2578 2577 -1
Branches 396 395 -1
=====================================================
- Hits 2070 2069 -1
Misses 428 428
Partials 80 80
🚀 New features to boost your workflow:
|
Maybe it is better to jsut have the top-level copyright file since it could be argued that |
Ahh! license theory! The PG license is unrestricted on derivative works...we can license under any terms we want for our unique code but if we used code from PG anywhere in that directory we can't magically relicense it to our desires...the files with the copied code would need to retain the PG license header. In this case it's worth a conversation on "do we get anything from the MIT license that we don't get from the PG license" as I think it makes it cleaner. Will take it up with Kai next week, this PR can move forward though. |
Need to modify the existing license to include the portions of code unique to Percona