Skip to content

Update COPYRIGHT #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025
Merged

Conversation

shoffman-percona
Copy link

Need to modify the existing license to include the portions of code unique to Percona

Need to modify the existing license to include the portions of code unique to Percona.
@it-percona-cla
Copy link

it-percona-cla commented May 7, 2025

CLA assistant check
All committers have signed the CLA.

@dutow
Copy link
Collaborator

dutow commented May 7, 2025

@shoffman-percona for now pg_tde has a separate license file: https://github.com/percona/postgres/blob/TDE_REL_17_STABLE/contrib/pg_tde/LICENSE

And 99% of our work is in that folder, we made very little changes to the postgres server itself. Should we keep that?

Fixed quotes
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.28%. Comparing base (784e45d) to head (7c83d81).
Report is 1 commits behind head on TDE_REL_17_STABLE.

❌ Your project status has failed because the head coverage (80.28%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           TDE_REL_17_STABLE     #317      +/-   ##
=====================================================
- Coverage              80.29%   80.28%   -0.01%     
=====================================================
  Files                     22       22              
  Lines                   2578     2577       -1     
  Branches                 396      395       -1     
=====================================================
- Hits                    2070     2069       -1     
  Misses                   428      428              
  Partials                  80       80              
Components Coverage Δ
access 82.77% <ø> (ø)
catalog 87.47% <ø> (ø)
common 91.80% <ø> (ø)
encryption 75.70% <ø> (ø)
keyring 71.83% <ø> (ø)
src 66.74% <ø> (ø)
smgr 96.96% <ø> (-0.04%) ⬇️
transam ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeltz
Copy link
Collaborator

jeltz commented May 8, 2025

Maybe it is better to jsut have the top-level copyright file since it could be argued that contrib/pg_tde partially is a derviate work from PostgreSQL. Though maybe that is a question for legal.

@shoffman-percona
Copy link
Author

Ahh! license theory! The PG license is unrestricted on derivative works...we can license under any terms we want for our unique code but if we used code from PG anywhere in that directory we can't magically relicense it to our desires...the files with the copied code would need to retain the PG license header. In this case it's worth a conversation on "do we get anything from the MIT license that we don't get from the PG license" as I think it makes it cleaner. Will take it up with Kai next week, this PR can move forward though.

@dutow dutow merged commit dee5a15 into percona:TDE_REL_17_STABLE May 8, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants