Skip to content

PMM-11312 --version #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 16, 2023
Merged

PMM-11312 --version #8

merged 3 commits into from
Jan 16, 2023

Conversation

YaroslavPodorvanov
Copy link

@YaroslavPodorvanov YaroslavPodorvanov commented Jan 9, 2023 •
edited
Loading

@YaroslavPodorvanov YaroslavPodorvanov self-assigned this Jan 9, 2023
@YaroslavPodorvanov YaroslavPodorvanov marked this pull request as draft January 9, 2023 23:58
This was referenced Jan 9, 2023
Merged
Merged
@YaroslavPodorvanov
Copy link
Author

YaroslavPodorvanov commented Jan 12, 2023 •
edited
Loading 

make release && ./azure_exporter --version
go build -ldflags="-X github.com/prometheus/common/version.Version=0.1.0-pre0 -X github.com/prometheus/common/version.Revision=b4d0a360aaf990527b1f81d84789b96cbf8ee4e5 -X github.com/prometheus/common/version.Branch=PMM-11312-build-exporters-version -X github.com/prometheus/common/version.BuildUser= -X github.com/prometheus/common/version.BuildDate=2023-01-13T01:50:22+0200 -s -w" -o ./azure_exporter
azure_exporter, version 0.1.0-pre0 (branch: PMM-11312-build-exporters-version, revision: b4d0a360aaf990527b1f81d84789b96cbf8ee4e5)
  build user:       
  build date:       2023-01-13T01:50:22+0200
  go version:       go1.18
  platform:         linux/amd64

This was referenced Jan 12, 2023
Closed
Merged
Merged
Merged
Merged
@YaroslavPodorvanov YaroslavPodorvanov marked this pull request as ready for review January 13, 2023 00:46
BupycHuk
BupycHuk reviewed Jan 16, 2023
View reviewed changes
Makefile
release:
go build -ldflags="$(GO_BUILD_LDFLAGS)" -o $(PMM_RELEASE_PATH)/azure_exporter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be azure_metrics_exporter?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be azure_exporter like in previous FBs

@YaroslavPodorvanov YaroslavPodorvanov merged commit b5302de into main Jan 16, 2023
@YaroslavPodorvanov YaroslavPodorvanov deleted the PMM-11312-build-exporters-version branch January 18, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BupycHuk BupycHuk BupycHuk left review comments

@ritbl ritbl Awaiting requested review from ritbl

@tshcherban tshcherban Awaiting requested review from tshcherban

Assignees

@YaroslavPodorvanov YaroslavPodorvanov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YaroslavPodorvanov @BupycHuk