add Stat() to vfs and ModTime to FileInfo when filewriting to vfs (microsoft#388)

Author: iisaduan

internal/bundled/embed.go

@@ -81,7 +81,7 @@ var rootEntries = []fs.DirEntry{
 	fs.FileInfoToDirEntry(&fileInfo{name: "libs", mode: fs.ModeDir}),
 }
 
-func (vfs *wrappedFS) GetEntries(path string) []fs.DirEntry {
+func (vfs *wrappedFS) GetEntries(path string) []vfs.DirEntry {
 	if rest, ok := splitPath(path); ok {
 		if rest == "" {
 			return slices.Clone(rootEntries)
@@ -94,6 +94,21 @@ func (vfs *wrappedFS) GetEntries(path string) []fs.DirEntry {
 	return vfs.fs.GetEntries(path)
 }
 
+func (vfs *wrappedFS) Stat(path string) vfs.FileInfo {
+	if rest, ok := splitPath(path); ok {
+		if rest == "" || rest == "libs" {
+			return &fileInfo{name: rest, mode: fs.ModeDir}
+		}
+		if libName, ok := strings.CutPrefix(rest, "libs/"); ok {
+			if lib, ok := embeddedContents[libName]; ok {
+				return &fileInfo{name: libName, size: int64(len(lib))}
+			}
+		}
+		return nil
+	}
+	return vfs.fs.Stat(path)
+}
+
 func (vfs *wrappedFS) WalkDir(root string, walkFn vfs.WalkDirFunc) error {
 	if rest, ok := splitPath(root); ok {
 		if err := vfs.walkDir(rest, walkFn); err != nil {

internal/vfs/internal/internal.go

@@ -40,7 +40,7 @@ func (vfs *Common) RootAndPath(path string) (fsys fs.FS, rootName string, rest s
 	return vfs.RootFor(rootName), rootName, rest
 }
 
-func (vfs *Common) stat(path string) fs.FileInfo {
+func (vfs *Common) Stat(path string) vfs.FileInfo {
 	fsys, _, rest := vfs.RootAndPath(path)
 	if fsys == nil {
 		return nil
@@ -53,12 +53,12 @@ func (vfs *Common) stat(path string) fs.FileInfo {
 }
 
 func (vfs *Common) FileExists(path string) bool {
-	stat := vfs.stat(path)
+	stat := vfs.Stat(path)
 	return stat != nil && !stat.IsDir()
 }
 
 func (vfs *Common) DirectoryExists(path string) bool {
-	stat := vfs.stat(path)
+	stat := vfs.Stat(path)
 	return stat != nil && stat.IsDir()
 }
 
@@ -86,7 +86,7 @@ func (vfs *Common) GetAccessibleEntries(path string) (result vfs.Entries) {
 
 		if entryType&fs.ModeSymlink != 0 {
 			// Easy case; UNIX-like system will clearly mark symlinks.
-			if stat := vfs.stat(path + "/" + entry.Name()); stat != nil {
+			if stat := vfs.Stat(path + "/" + entry.Name()); stat != nil {
 				addToResult(entry.Name(), stat.Mode())
 			}
 			continue
@@ -97,7 +97,7 @@ func (vfs *Common) GetAccessibleEntries(path string) (result vfs.Entries) {
 			// TODO(jakebailey): use syscall.Win32FileAttributeData instead
 			fullPath := path + "/" + entry.Name()
 			if realpath := vfs.Realpath(fullPath); fullPath != realpath {
-				if stat := vfs.stat(realpath); stat != nil {
+				if stat := vfs.Stat(realpath); stat != nil {
 					addToResult(entry.Name(), stat.Mode())
 				}
 			}
@@ -108,7 +108,7 @@ func (vfs *Common) GetAccessibleEntries(path string) (result vfs.Entries) {
 	return result
 }
 
-func (vfs *Common) GetEntries(path string) []fs.DirEntry {
+func (vfs *Common) GetEntries(path string) []vfs.DirEntry {
 	fsys, _, rest := vfs.RootAndPath(path)
 	if fsys == nil {
 		return nil

internal/vfs/iovfs/iofs.go

@@ -122,10 +122,15 @@ func (vfs *ioFS) GetAccessibleEntries(path string) vfs.Entries {
 	return vfs.common.GetAccessibleEntries(path)
 }
 
-func (vfs *ioFS) GetEntries(path string) []fs.DirEntry {
+func (vfs *ioFS) GetEntries(path string) []vfs.DirEntry {
 	return vfs.common.GetEntries(path)
 }
 
+func (vfs *ioFS) Stat(path string) vfs.FileInfo {
+	_ = internal.RootLength(path) // Assert path is rooted
+	return vfs.common.Stat(path)
+}
+
 func (vfs *ioFS) ReadFile(path string) (contents string, ok bool) {
 	return vfs.common.ReadFile(path)
 }

internal/vfs/osvfs/os.go

@@ -2,7 +2,6 @@ package osvfs
 
 import (
 	"fmt"
-	"io/fs"
 	"os"
 	"path/filepath"
 	"runtime"
@@ -93,10 +92,14 @@ func (vfs *osFS) GetAccessibleEntries(path string) vfs.Entries {
 	return vfs.common.GetAccessibleEntries(path)
 }
 
-func (vfs *osFS) GetEntries(path string) []fs.DirEntry {
+func (vfs *osFS) GetEntries(path string) []vfs.DirEntry {
 	return vfs.common.GetEntries(path)
 }
 
+func (vfs *osFS) Stat(path string) vfs.FileInfo {
+	return vfs.common.Stat(path)
+}
+
 func (vfs *osFS) WalkDir(root string, walkFn vfs.WalkDirFunc) error {
 	return vfs.common.WalkDir(root, walkFn)
 }

internal/vfs/vfs.go

@@ -26,7 +26,9 @@ type FS interface {
 	GetAccessibleEntries(path string) Entries
 
 	// GetEntries returns the entries in the specified directory.
-	GetEntries(path string) []fs.DirEntry
+	GetEntries(path string) []DirEntry
+
+	Stat(path string) FileInfo
 
 	// WalkDir walks the file tree rooted at root, calling walkFn for each file or directory in the tree.
 	// It is has the same behavior as [fs.WalkDir], but with paths as [string].
@@ -42,8 +44,13 @@ type Entries struct {
 	Directories []string
 }
 
-// DirEntry is [fs.DirEntry].
-type DirEntry = fs.DirEntry
+type (
+	// DirEntry is [fs.DirEntry].
+	DirEntry = fs.DirEntry
+
+	// FileInfo is [fs.FileInfo].
+	FileInfo = fs.FileInfo
+)
 
 var (
 	ErrInvalid    = fs.ErrInvalid    // "invalid argument"

internal/vfs/vfstest/vfstest.go

@@ -9,6 +9,7 @@ import (
 	"strings"
 	"sync"
 	"testing/fstest"
+	"time"
 
 	"github.com/microsoft/typescript-go/internal/tspath"
 	"github.com/microsoft/typescript-go/internal/vfs"
@@ -333,8 +334,9 @@ func (m *mapFS) WriteFile(path string, data []byte, perm fs.FileMode) error {
 	}
 
 	m.setEntry(path, m.getCanonicalPath(path), fstest.MapFile{
-		Data: data,
-		Mode: perm &^ umask,
+		Data:    data,
+		ModTime: time.Now(),
+		Mode:    perm &^ umask,
 	})
 
 	return nil