Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore email attachment functionality #112

Open
orangejulius opened this issue Jul 24, 2017 · 0 comments
Open

Restore email attachment functionality #112

orangejulius opened this issue Jul 24, 2017 · 0 comments
Labels

Comments

@orangejulius
Copy link
Member

In #111, we were forced to temporarily disable sending of our response details attachment with our acceptance test emails. Apparently Amazon SQS has a strict 10MB limit and we were hitting that.

In the long run, this attachment is really useful. It lets us see the full debug output for queries that didn't work, which may help track down configuration issues and is especially helpful with transient errors.

However, we need to ensure the size is manageable for a long time (since we of course always want to add more acceptance tests).

Some ideas to manage this include:

  • Compressing the output and setting proper headers so that email clients handle it transparently
  • Pruning the debug output where there is non-essential information
  • Only returning debug output for test cases that failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant