Skip to content

Commit 98b3815

Browse files
vishalshrm539Sharmatumms2021389
authored
Moved tinyMCE to 6.8.6, sorted public-api file, and removed duplicate function (#314)
* Moved tinyMCE to 6.8.6, sorted public-api file, and removed duplicate function * removed unnecessary packages --------- Co-authored-by: Sharma <vishal.sharma@in.pega.com> Co-authored-by: tumms2021389 <97188066+tumms2021389@users.noreply.github.com>
1 parent a052096 commit 98b3815

File tree

8 files changed

+65
-77
lines changed

8 files changed

+65
-77
lines changed

package-lock.json

Lines changed: 34 additions & 36 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,7 @@
9494
"@angular/language-service": "^18.2.12",
9595
"@pega/configs": "^0.16.2",
9696
"@pega/constellationjs": "~24.2.2",
97-
"@pega/eslint-config": "^0.16.2",
9897
"@pega/pcore-pconnect-typedefs": "~3.2.2",
99-
"@pega/prettier-config": "^0.16.2",
10098
"@playwright/test": "^1.40.1",
10199
"@types/jasmine": "~5.1.4",
102100
"@types/jasminewd2": "~2.0.13",
@@ -123,7 +121,7 @@
123121
"npm-run-all": "^4.1.5",
124122
"postcss": "^8.4.49",
125123
"shx": "^0.3.4",
126-
"tinymce": "^7.2.1",
124+
"tinymce": "^6.8.6",
127125
"ts-node": "~10.9.2",
128126
"typescript": "^5.4.5",
129127
"webpack": "^5.96.1"

packages/angular-sdk-components/src/lib/_components/template/field-group-template/field-group-template.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { AngularPConnectData, AngularPConnectService } from '../../../_bridge/an
66
import { buildView, getReferenceList } from '../../../_helpers/field-group-utils';
77
import { Utils } from '../../../_helpers/utils';
88
import { ComponentMapperComponent } from '../../../_bridge/component-mapper/component-mapper.component';
9-
import { evaluateAllowRowAction } from './utils';
9+
import { evaluateAllowRowAction } from '../utils';
1010

1111
interface FieldGroupTemplateProps {
1212
// If any, enter additional props that only exist on this component

packages/angular-sdk-components/src/lib/_components/template/field-group-template/utils.ts

Lines changed: 0 additions & 9 deletions
This file was deleted.

packages/angular-sdk-components/src/lib/_components/template/simple-table-manual/helpers.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -294,19 +294,3 @@ export const createPConnect = (contextName, referenceList, pageReference) => {
294294

295295
return getPConnect();
296296
};
297-
298-
/**
299-
* This method evaluates whether a row action is allowed based on the provided conditions.
300-
* @param {string|boolean|undefined} allowRowDelete - The condition for allowing row deletion.
301-
* @param {object} rowData - The data of the row being evaluated.
302-
* @returns {boolean} - Returns true if the row action is allowed, false otherwise.
303-
*/
304-
export const evaluateAllowRowAction = (allowRowDelete, rowData) => {
305-
if (allowRowDelete === undefined || allowRowDelete === true) return true;
306-
if (allowRowDelete.startsWith?.('@E ')) {
307-
const expression = allowRowDelete.replace('@E ', '');
308-
// @ts-ignore - Expected 3 arguments, but got 2
309-
return PCore.getExpressionEngine().evaluate(expression, rowData);
310-
}
311-
return false;
312-
};

packages/angular-sdk-components/src/lib/_components/template/simple-table-manual/simple-table-manual.component.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ import { ComponentMapperComponent } from '../../../_bridge/component-mapper/comp
1616
import { AngularPConnectData, AngularPConnectService } from '../../../_bridge/angular-pconnect';
1717
import { DatapageService } from '../../../_services/datapage.service';
1818
import { getReferenceList } from '../../../_helpers/field-group-utils';
19-
import { buildFieldsForTable, evaluateAllowRowAction, filterDataByCommonFields, filterDataByDate, getContext } from './helpers';
19+
import { buildFieldsForTable, filterDataByCommonFields, filterDataByDate, getContext } from './helpers';
20+
import { evaluateAllowRowAction } from '../utils';
2021
import { Utils } from '../../../_helpers/utils';
2122
import { getSeconds } from '../../../_helpers/common';
2223

packages/angular-sdk-components/src/lib/_components/template/utils.ts

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,19 @@ export function filterForFieldValueList(fields: any) {
2121
value
2222
}));
2323
}
24+
25+
/**
26+
* This method evaluates whether a row action is allowed based on the provided conditions.
27+
* @param {string|boolean|undefined} allowRowDelete - The condition for allowing row deletion.
28+
* @param {object} rowData - The data of the row being evaluated.
29+
* @returns {boolean} - Returns true if the row action is allowed, false otherwise.
30+
*/
31+
export const evaluateAllowRowAction = (allowRowDelete, rowData) => {
32+
if (allowRowDelete === undefined || allowRowDelete === true) return true;
33+
if (allowRowDelete.startsWith?.('@E ')) {
34+
const expression = allowRowDelete.replace('@E ', '');
35+
// @ts-ignore - Expected 3 arguments, but got 2
36+
return PCore.getExpressionEngine().evaluate(expression, rowData);
37+
}
38+
return false;
39+
};

packages/angular-sdk-components/src/public-api.ts

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
* Public API Surface of angular-sdk-components
55
*/
66

7+
export * from './sdk-local-component-map';
8+
79
export * from './lib/_bridge/component-mapper/component-mapper.component';
810
export * from './lib/_bridge/helpers/sdk_component_map';
911
export * from './lib/_bridge/angular-pconnect';
@@ -84,6 +86,7 @@ export * from './lib/_components/template/page/page.component';
8486
export * from './lib/_components/template/promoted-filters/promoted-filters.component';
8587
export * from './lib/_components/template/repeating-structures/repeating-structures.component';
8688
export * from './lib/_components/template/simple-table/simple-table.component';
89+
export * from './lib/_components/template/simple-table-manual/helpers';
8790
export * from './lib/_components/template/simple-table-manual/simple-table-manual.component';
8891
export * from './lib/_components/template/simple-table-select/simple-table-select.component';
8992
export * from './lib/_components/template/single-reference-readonly/single-reference-readonly.component';
@@ -96,7 +99,6 @@ export * from './lib/_components/template/two-column-tab/two-column-tab.componen
9699
export * from './lib/_components/template/wide-narrow-form/wide-narrow-form.component';
97100
export * from './lib/_components/template/wide-narrow-page/wide-narrow-page.component';
98101
export * from './lib/_components/template/utils';
99-
export * from './lib/_components/template/simple-table-manual/helpers';
100102

101103
export * from './lib/_components/widget/app-announcement/app-announcement.component';
102104
export * from './lib/_components/widget/attachment/attachment.component';
@@ -123,36 +125,34 @@ export * from './lib/_components/designSystemExtension/rich-text-editor/rich-tex
123125

124126
export * from './lib/_directives/thousand-seperator.directive';
125127

126-
export * from './lib/_services/server-config.service';
128+
export * from './lib/_services/banner.service';
127129
export * from './lib/_services/case.service';
128130
export * from './lib/_services/datapage.service';
129-
export * from './lib/_services/banner.service';
130131
export * from './lib/_services/endpoints';
132+
export * from './lib/_services/server-config.service';
131133

132134
export * from './lib/_helpers/case-utils';
133-
export * from './lib/_helpers/currency-utils';
134135
export * from './lib/_helpers/common';
135136
export * from './lib/_helpers/createstage-utils';
137+
export * from './lib/_helpers/currency-utils';
136138
export * from './lib/_helpers/date-format-utils';
137139
export * from './lib/_helpers/event-util';
138140
export * from './lib/_helpers/field-group-utils';
139-
export * from './lib/_helpers/formatters/format-utils';
140-
export * from './lib/_helpers/formatters/currency-map';
141-
export * from './lib/_helpers/formatters/date';
141+
export * from './lib/_helpers/filter-utils';
142142
export * from './lib/_helpers/formatters/boolean';
143143
export * from './lib/_helpers/formatters/currency';
144+
export * from './lib/_helpers/formatters/currency-map';
145+
export * from './lib/_helpers/formatters/date';
146+
export * from './lib/_helpers/formatters/format-utils';
144147
export * from './lib/_helpers/formatters/index';
148+
export * from './lib/_helpers/instructions-utils';
145149
export * from './lib/_helpers/tab-utils';
146150
export * from './lib/_helpers/template-utils';
147151
export * from './lib/_helpers/utils';
148152
export * from './lib/_helpers/versionHelpers';
149-
export * from './lib/_helpers/filter-utils';
150-
export * from './lib/_helpers/instructions-utils';
151153

152154
export * from './lib/_messages/error-messages.service';
153155
export * from './lib/_messages/progress-spinner.service';
154156
export * from './lib/_messages/update-worklist.service';
155157

156158
export * from './lib/_types/PConnProps.interface';
157-
158-
export * from './sdk-local-component-map';

0 commit comments

Comments
 (0)