Fix: Do not use each

localheinz · localheinz · commit 3efed931d74d · 2023-04-07T14:33:32.000+02:00
diff --git a/Text/Diff/Engine/native.php b/Text/Diff/Engine/native.php
@@ -192,15 +192,16 @@ function _diag ($xoff, $xlim, $yoff, $ylim, $nchunks)
                 }
                 $matches = $ymatches[$line];
                 reset($matches);
-                while (list(, $y) = each($matches)) {
+
+                foreach ($matches as list(, $y)) {
                     if (empty($this->in_seq[$y])) {
                         $k = $this->_lcsPos($y);
                         assert($k > 0);
                         $ymids[$k] = $ymids[$k - 1];
                         break;
                     }
                 }
-                while (list(, $y) = each($matches)) {
+                foreach ($matches as list(, $y)) {
                     if ($y > $this->seq[$k - 1]) {
                         assert($y <= $this->seq[$k]);
                         /* Optimization: this is a common case: next match is

Original file line number	Diff line number	Diff line change
`@@ -192,15 +192,16 @@ function _diag ($xoff, $xlim, $yoff, $ylim, $nchunks)`
`192`	`192`	`}`
`193`	`193`	`$matches = $ymatches[$line];`
`194`	`194`	`reset($matches);`
`195`		`- while (list(, $y) = each($matches)) {`
	`195`	`+`
	`196`	`+ foreach ($matches as list(, $y)) {`
`196`	`197`	`if (empty($this->in_seq[$y])) {`
`197`	`198`	`$k = $this->_lcsPos($y);`
`198`	`199`	`assert($k > 0);`
`199`	`200`	`$ymids[$k] = $ymids[$k - 1];`
`200`	`201`	`break;`
`201`	`202`	`}`
`202`	`203`	`}`
`203`		`- while (list(, $y) = each($matches)) {`
	`204`	`+ foreach ($matches as list(, $y)) {`
`204`	`205`	`if ($y > $this->seq[$k - 1]) {`
`205`	`206`	`assert($y <= $this->seq[$k]);`
`206`	`207`	`/* Optimization: this is a common case: next match is`