Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: Questionable practise of directory usage especially for GHES usage #663

Open
3 tasks done
ghost opened this issue Oct 14, 2021 · 0 comments
Open
3 tasks done
Assignees
Labels
enhancement New feature or request proposal

Comments

@ghost
Copy link

ghost commented Oct 14, 2021

Checklist

  • I am using the latest version of this action.
  • I have read the latest README and followed the instructions.
  • I have read the latest GitHub Actions official documentation and learned the basic spec and concepts.

Describe your proposal

const workDirName = path.join(homeDir, `actions_github_pages_${unixTime}`);
is accessing a directory outside of the current _temp workspace directory which is created for each run.

This is not an issue on github.com as they have ephemeral runners that get destroyed or reset after each run. For GHES though the runners sometimes work for more than one job (maybe also a questionable practise) but then their disks run full because the directory from

const workDirName = path.join(homeDir, `actions_github_pages_${unixTime}`);
is not wiped as its not part of the temporary workspace.

Describe the solution you'd like

I am happy/open to make a PR to refactor that logic, but I'd like to get advice first on why that architecture was chosen. Also, where would these files best belong if we make a generic PR (that does not accept the path as parameter but defaults to something inside the temporary workspace)?

Describe alternatives you've considered

Making a PR to hand in a parameter to define the working-directory from external.

Additional context

Our disks ran full that morning for 1 runner that lived quite a time and then our jobs started to fail on npm install as there was no disk space left.

@ghost ghost added the proposal label Oct 14, 2021
@ghost ghost assigned peaceiris Oct 14, 2021
@peaceiris peaceiris added the enhancement New feature or request label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request proposal
Projects
None yet
Development

No branches or pull requests

1 participant